Skip to content

Conversation

@mattip
Copy link
Contributor

@mattip mattip commented Jun 15, 2021

This is the result of

  • installing the pytorch 1.9 latest rc
  • installing vision from the 0.10rc1 tag
cd docs
make html
cd ..
git checkout gh-pages
mkdir 0.10
cp -r docs/build/html/* 0.10

I also edited the versions.html to add the version documentation, and changed the symlink for stable to point to 0.10.

Please check carefully that there are no post-rc1 documentation changes (that belong in master and not the release).

@mattip
Copy link
Contributor Author

mattip commented Jun 15, 2021

A preview can be seen on my fork's github pages https://mattip.github.io/vision/0.10/, just be careful that some of the links lead off the site (like the version dropdown).

@mattip
Copy link
Contributor Author

mattip commented Jun 15, 2021

@brianjo

@mattip
Copy link
Contributor Author

mattip commented Jun 15, 2021

#4059 would have done most of this work when the 0.10 tag is created, @brianjo asked me to prepare this as a backup if it doesn't work

@mattip
Copy link
Contributor Author

mattip commented Jun 15, 2021

Even if creating the tag works, another PR will be needed to adjust stable -> 0.10 and to update the versions.html

@NicolasHug
Copy link
Member

Thanks for the PR @mattip !

Please check carefully that there are no post-rc1 documentation changes (that belong in master and not the release).

As long as you ran make html from the 0.10rc1 tag, there should be no issue right?

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattip this PR LGTM modulo confirmation of my previous comment #4061 (comment)

Also IIUC, you suggest we wait and see if pushing the tag works properly before considering merging this PR, correct?

Thanks!

@mattip
Copy link
Contributor Author

mattip commented Jun 15, 2021

As long as you ran make html from the 0.10rc1 tag, there should be no issue right?

I hope so. Sometimes the docstrings can be tricky, I don't know this repo well. I built a CPU version, does that matter?

Also IIUC, you suggest we wait and see if pushing the tag works properly

Yes. Please ping me when it happens.

@NicolasHug
Copy link
Member

I hope so. Sometimes the docstrings can be tricky, I don't know this repo well. I built a CPU version, does that matter?

OK, as long as we didn't include anything in the v0.10 by mistake (which I doubt), everything should be OK. Building the docs on CPU is just fine. Thanks!

@NicolasHug
Copy link
Member

Even if creating the tag works, another PR will be needed to adjust stable -> 0.10 and to update the versions.html

@mattip should we do that before or after pushing the tag?

@mattip
Copy link
Contributor Author

mattip commented Jun 15, 2021

The versions.html and stable link should be adjusted after the final docs are in position, so after the tag /merging this PR.

Edit: no need if this PR is merged

@fmassa
Copy link
Member

fmassa commented Jun 15, 2021

The tag has been created in https://github.com/pytorch/vision/releases/tag/v0.10.0

Let's see if the docs get built

@fmassa fmassa merged commit d792eac into pytorch:gh-pages Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants