-
Notifications
You must be signed in to change notification settings - Fork 7.2k
add v0.10 documentation, adjust versions.html #4061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A preview can be seen on my fork's github pages https://mattip.github.io/vision/0.10/, just be careful that some of the links lead off the site (like the version dropdown). |
|
Even if creating the tag works, another PR will be needed to adjust stable -> 0.10 and to update the versions.html |
|
Thanks for the PR @mattip !
As long as you ran |
NicolasHug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattip this PR LGTM modulo confirmation of my previous comment #4061 (comment)
Also IIUC, you suggest we wait and see if pushing the tag works properly before considering merging this PR, correct?
Thanks!
I hope so. Sometimes the docstrings can be tricky, I don't know this repo well. I built a CPU version, does that matter?
Yes. Please ping me when it happens. |
OK, as long as we didn't include anything in the v0.10 by mistake (which I doubt), everything should be OK. Building the docs on CPU is just fine. Thanks! |
@mattip should we do that before or after pushing the tag? |
|
The versions.html and stable link should be adjusted after the final docs are in position, so after the tag Edit: no need if this PR is merged |
|
The tag has been created in https://github.com/pytorch/vision/releases/tag/v0.10.0 Let's see if the docs get built |
This is the result of
I also edited the versions.html to add the version documentation, and changed the symlink for stable to point to 0.10.
Please check carefully that there are no post-rc1 documentation changes (that belong in master and not the release).