Move version definition from setup.py to version.txt #3202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
approved these changes
Dec 22, 2020
Contributor
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Looks good to me :)
A minimal change. For a bigger change, we can also inspire from https://github.com/pytorch/pytorch/blob/c348faedc4c3e48182a9b2d74f1da861624d0f87/tools/generate_torch_version.py#L13
Contributor
Author
|
@seemethere this might be of interest to you for the release/CI scripts. |
Member
|
Thanks for the heads up, this looks fine to me as long as we retain the ability to set it as an environment variable |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 23, 2020
Reviewed By: fmassa Differential Revision: D25679212 fbshipit-source-id: ab567b28e454bb5e8ac741e6d7798786dcbb6b3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for FBcode