Skip to content

Commit e4737e2

Browse files
YosuaMichaeldatumbox
authored andcommitted
[fbsync] Remove publication_year and interpolation meta (#5848)
Summary: * Remove publication_year and interpolation meta * Add type to _COMMON_META and _COMMON_SWAG_META to prevent error from mypy check * Remove test to check interpolation and publication_year meta Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095723 fbshipit-source-id: 15e7c00093bcf18393e3e5744d72734cf6fa7aac Co-authored-by: Vasilis Vryniotis <[email protected]>
1 parent d9f6846 commit e4737e2

34 files changed

+34
-129
lines changed

test/test_extended_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def test_naming_conventions(model_fn):
8181
def test_schema_meta_validation(model_fn):
8282
classification_fields = ["size", "categories", "acc@1", "acc@5", "min_size"]
8383
defaults = {
84-
"all": ["task", "architecture", "publication_year", "interpolation", "recipe", "num_params"],
84+
"all": ["task", "architecture", "recipe", "num_params"],
8585
"models": classification_fields,
8686
"detection": ["categories", "map"],
8787
"quantization": classification_fields + ["backend", "quantization", "unquantized"],

torchvision/models/alexnet.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import torch
55
import torch.nn as nn
66

7-
from ..transforms._presets import ImageClassification, InterpolationMode
7+
from ..transforms._presets import ImageClassification
88
from ..utils import _log_api_usage_once
99
from ._api import WeightsEnum, Weights
1010
from ._meta import _IMAGENET_CATEGORIES
@@ -59,12 +59,10 @@ class AlexNet_Weights(WeightsEnum):
5959
meta={
6060
"task": "image_classification",
6161
"architecture": "AlexNet",
62-
"publication_year": 2012,
6362
"num_params": 61100840,
6463
"size": (224, 224),
6564
"min_size": (63, 63),
6665
"categories": _IMAGENET_CATEGORIES,
67-
"interpolation": InterpolationMode.BILINEAR,
6866
"recipe": "https://github.com/pytorch/vision/tree/main/references/classification#alexnet-and-vgg",
6967
"acc@1": 56.522,
7068
"acc@5": 79.066,

torchvision/models/convnext.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
from ..ops.misc import Conv2dNormActivation
99
from ..ops.stochastic_depth import StochasticDepth
10-
from ..transforms._presets import ImageClassification, InterpolationMode
10+
from ..transforms._presets import ImageClassification
1111
from ..utils import _log_api_usage_once
1212
from ._api import WeightsEnum, Weights
1313
from ._meta import _IMAGENET_CATEGORIES
@@ -206,11 +206,9 @@ def _convnext(
206206
_COMMON_META = {
207207
"task": "image_classification",
208208
"architecture": "ConvNeXt",
209-
"publication_year": 2022,
210209
"size": (224, 224),
211210
"min_size": (32, 32),
212211
"categories": _IMAGENET_CATEGORIES,
213-
"interpolation": InterpolationMode.BILINEAR,
214212
"recipe": "https://github.com/pytorch/vision/tree/main/references/classification#convnext",
215213
}
216214

torchvision/models/densenet.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import torch.utils.checkpoint as cp
1010
from torch import Tensor
1111

12-
from ..transforms._presets import ImageClassification, InterpolationMode
12+
from ..transforms._presets import ImageClassification
1313
from ..utils import _log_api_usage_once
1414
from ._api import WeightsEnum, Weights
1515
from ._meta import _IMAGENET_CATEGORIES
@@ -268,11 +268,9 @@ def _densenet(
268268
_COMMON_META = {
269269
"task": "image_classification",
270270
"architecture": "DenseNet",
271-
"publication_year": 2016,
272271
"size": (224, 224),
273272
"min_size": (29, 29),
274273
"categories": _IMAGENET_CATEGORIES,
275-
"interpolation": InterpolationMode.BILINEAR,
276274
"recipe": "https://github.com/pytorch/vision/pull/116",
277275
}
278276

torchvision/models/detection/faster_rcnn.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from torchvision.ops import MultiScaleRoIAlign
77

88
from ...ops import misc as misc_nn_ops
9-
from ...transforms._presets import ObjectDetection, InterpolationMode
9+
from ...transforms._presets import ObjectDetection
1010
from .._api import WeightsEnum, Weights
1111
from .._meta import _COCO_CATEGORIES
1212
from .._utils import handle_legacy_interface, _ovewrite_value_param
@@ -372,9 +372,7 @@ def forward(self, x):
372372
_COMMON_META = {
373373
"task": "image_object_detection",
374374
"architecture": "FasterRCNN",
375-
"publication_year": 2015,
376375
"categories": _COCO_CATEGORIES,
377-
"interpolation": InterpolationMode.BILINEAR,
378376
}
379377

380378

@@ -398,7 +396,6 @@ class FasterRCNN_ResNet50_FPN_V2_Weights(WeightsEnum):
398396
transforms=ObjectDetection,
399397
meta={
400398
**_COMMON_META,
401-
"publication_year": 2021,
402399
"num_params": 43712278,
403400
"recipe": "https://github.com/pytorch/vision/pull/5763",
404401
"map": 46.7,

torchvision/models/detection/fcos.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from ...ops import boxes as box_ops
1212
from ...ops import misc as misc_nn_ops
1313
from ...ops.feature_pyramid_network import LastLevelP6P7
14-
from ...transforms._presets import ObjectDetection, InterpolationMode
14+
from ...transforms._presets import ObjectDetection
1515
from ...utils import _log_api_usage_once
1616
from .._api import WeightsEnum, Weights
1717
from .._meta import _COCO_CATEGORIES
@@ -653,10 +653,8 @@ class FCOS_ResNet50_FPN_Weights(WeightsEnum):
653653
meta={
654654
"task": "image_object_detection",
655655
"architecture": "FCOS",
656-
"publication_year": 2019,
657656
"num_params": 32269600,
658657
"categories": _COCO_CATEGORIES,
659-
"interpolation": InterpolationMode.BILINEAR,
660658
"recipe": "https://github.com/pytorch/vision/tree/main/references/detection#fcos-resnet-50-fpn",
661659
"map": 39.2,
662660
},

torchvision/models/detection/keypoint_rcnn.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from torchvision.ops import MultiScaleRoIAlign
66

77
from ...ops import misc as misc_nn_ops
8-
from ...transforms._presets import ObjectDetection, InterpolationMode
8+
from ...transforms._presets import ObjectDetection
99
from .._api import WeightsEnum, Weights
1010
from .._meta import _COCO_PERSON_CATEGORIES, _COCO_PERSON_KEYPOINT_NAMES
1111
from .._utils import handle_legacy_interface, _ovewrite_value_param
@@ -310,10 +310,8 @@ def forward(self, x):
310310
_COMMON_META = {
311311
"task": "image_object_detection",
312312
"architecture": "KeypointRCNN",
313-
"publication_year": 2017,
314313
"categories": _COCO_PERSON_CATEGORIES,
315314
"keypoint_names": _COCO_PERSON_KEYPOINT_NAMES,
316-
"interpolation": InterpolationMode.BILINEAR,
317315
}
318316

319317

torchvision/models/detection/mask_rcnn.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from torchvision.ops import MultiScaleRoIAlign
66

77
from ...ops import misc as misc_nn_ops
8-
from ...transforms._presets import ObjectDetection, InterpolationMode
8+
from ...transforms._presets import ObjectDetection
99
from .._api import WeightsEnum, Weights
1010
from .._meta import _COCO_CATEGORIES
1111
from .._utils import handle_legacy_interface, _ovewrite_value_param
@@ -354,7 +354,6 @@ def __init__(self, in_channels, dim_reduced, num_classes):
354354
"task": "image_object_detection",
355355
"architecture": "MaskRCNN",
356356
"categories": _COCO_CATEGORIES,
357-
"interpolation": InterpolationMode.BILINEAR,
358357
}
359358

360359

@@ -364,7 +363,6 @@ class MaskRCNN_ResNet50_FPN_Weights(WeightsEnum):
364363
transforms=ObjectDetection,
365364
meta={
366365
**_COMMON_META,
367-
"publication_year": 2017,
368366
"num_params": 44401393,
369367
"recipe": "https://github.com/pytorch/vision/tree/main/references/detection#mask-r-cnn",
370368
"map": 37.9,
@@ -380,7 +378,6 @@ class MaskRCNN_ResNet50_FPN_V2_Weights(WeightsEnum):
380378
transforms=ObjectDetection,
381379
meta={
382380
**_COMMON_META,
383-
"publication_year": 2021,
384381
"num_params": 46359409,
385382
"recipe": "https://github.com/pytorch/vision/pull/5773",
386383
"map": 47.4,

torchvision/models/detection/retinanet.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from ...ops import boxes as box_ops
1212
from ...ops import misc as misc_nn_ops
1313
from ...ops.feature_pyramid_network import LastLevelP6P7
14-
from ...transforms._presets import ObjectDetection, InterpolationMode
14+
from ...transforms._presets import ObjectDetection
1515
from ...utils import _log_api_usage_once
1616
from .._api import WeightsEnum, Weights
1717
from .._meta import _COCO_CATEGORIES
@@ -677,7 +677,6 @@ def forward(self, images, targets=None):
677677
"task": "image_object_detection",
678678
"architecture": "RetinaNet",
679679
"categories": _COCO_CATEGORIES,
680-
"interpolation": InterpolationMode.BILINEAR,
681680
}
682681

683682

@@ -687,7 +686,6 @@ class RetinaNet_ResNet50_FPN_Weights(WeightsEnum):
687686
transforms=ObjectDetection,
688687
meta={
689688
**_COMMON_META,
690-
"publication_year": 2017,
691689
"num_params": 34014999,
692690
"recipe": "https://github.com/pytorch/vision/tree/main/references/detection#retinanet",
693691
"map": 36.4,
@@ -702,7 +700,6 @@ class RetinaNet_ResNet50_FPN_V2_Weights(WeightsEnum):
702700
transforms=ObjectDetection,
703701
meta={
704702
**_COMMON_META,
705-
"publication_year": 2019,
706703
"num_params": 38198935,
707704
"recipe": "https://github.com/pytorch/vision/pull/5756",
708705
"map": 41.5,

torchvision/models/detection/ssd.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from torch import nn, Tensor
88

99
from ...ops import boxes as box_ops
10-
from ...transforms._presets import ObjectDetection, InterpolationMode
10+
from ...transforms._presets import ObjectDetection
1111
from ...utils import _log_api_usage_once
1212
from .._api import WeightsEnum, Weights
1313
from .._meta import _COCO_CATEGORIES
@@ -32,11 +32,9 @@ class SSD300_VGG16_Weights(WeightsEnum):
3232
meta={
3333
"task": "image_object_detection",
3434
"architecture": "SSD",
35-
"publication_year": 2015,
3635
"num_params": 35641826,
3736
"size": (300, 300),
3837
"categories": _COCO_CATEGORIES,
39-
"interpolation": InterpolationMode.BILINEAR,
4038
"recipe": "https://github.com/pytorch/vision/tree/main/references/detection#ssd300-vgg16",
4139
"map": 25.1,
4240
},

0 commit comments

Comments
 (0)