This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Add sacremoses / toktok tokenizers #332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I believe this change is necessary since moses is deleted in nltk becasue of license issues. |
Contributor
Author
Contributor
Author
|
@jekbradbury I feel that the breaking test has something to do with 14418da (jekbradbury/revtok#3). Please check it out when you manage. I will merge a patch to (currently) ignore that test in python 2.x. |
Contributor
Author
|
Closing in favor of #361 |
Contributor
|
@mttk Python2.7 bug is fixed in the new sacremoses version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated as recommended in #306.