This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Avoid using std::regex and fix lint errors #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nayef211
approved these changes
Oct 6, 2022
Contributor
Nayef211
left a comment
Nayef211
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing these errors
abhinavarora
approved these changes
Oct 10, 2022
Contributor
abhinavarora
left a comment
abhinavarora
left a comment
There was a problem hiding this comment.
Changes look good to me!
Contributor
|
I'll go ahead and merge these changes as the unit test failures seem completely unrelated to this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid using std::regex and fix lint errors
This change fixes the lint errors raised from merging #1916 into fbcode.
Types of changes
[x ] Fixes
Changes made
std::regexusage and opted to usere2Testing
pre-commit