Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Sep 13, 2022

  • Deleting outdated docs on experimental datasets
  • Update pytorch_sphinx_theme to latest commit
  • This also updates torchtext docs with new Terms / Privacy links pointing to Linux foundation

Note we still pin the theme version so that our customization does not break randomly similar to pytorch/audio#2679

- Deleting outdated docs on experimental datasets
@Nayef211 Nayef211 changed the title Delete experimental_datasets_raw.rst Update doc theme to the latest Sep 15, 2022
@Nayef211 Nayef211 marked this pull request as ready for review September 15, 2022 21:54
@Nayef211 Nayef211 requested a review from mthrok September 15, 2022 21:54
Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intended change looks good but there are some other render issues observed.

Screen Shot 2022-09-16 at 8 08 40 AM

Follow up:

  • pin versions of Sphinx-related tools (example)
  • Override CSS so that example gallery is rendered properly.

nit: I'd have split the PR to deletion and theme update.

@Nayef211
Copy link
Contributor Author

Follow up:

  • pin versions of Sphinx-related tools (example)
  • Override CSS so that example gallery is rendered properly.

Thanks for the feedback. Let me create a followup PR to do this.

nit: I'd have split the PR to deletion and theme update.

I think the reason I did this in one is because @svekars mentioned the following

To update torchtext docs to pick up this change, you need to rebuild your docs. It can be a super simple PR that just changes a word or fixes a typo under the docs/source dir.

In hindsight, maybe the update to sphinx-theme was enough to rebuild the docs.

@Nayef211 Nayef211 merged commit 94c53cb into pytorch:main Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants