Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Mar 9, 2022

Testing

  • pytest test_iwslt2016.py
  • pytest test_iwslt2017.py

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1642 (ab553b7) into main (7209421) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1642   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files          58       58           
  Lines        2497     2497           
=======================================
  Hits         2137     2137           
  Misses        360      360           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7209421...ab553b7. Read the comment docs.

@Nayef211 Nayef211 marked this pull request as ready for review March 9, 2022 01:51
@Nayef211 Nayef211 requested a review from parmeet March 9, 2022 01:51
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this. I think this is the reason for random test failure.

@Nayef211 Nayef211 merged commit 2dd5e25 into pytorch:main Mar 9, 2022
@Nayef211 Nayef211 deleted the feature/add_utf8_iwslt branch March 9, 2022 04:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants