From ecf6f4af59f01dad4f4f5b7c20dba0d880e36f71 Mon Sep 17 00:00:00 2001 From: nayef211 Date: Thu, 3 Feb 2022 18:56:14 -0800 Subject: [PATCH 1/2] Added test for penntreebank --- test/datasets/test_penntreebank.py | 75 ++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 test/datasets/test_penntreebank.py diff --git a/test/datasets/test_penntreebank.py b/test/datasets/test_penntreebank.py new file mode 100644 index 0000000000..1468191143 --- /dev/null +++ b/test/datasets/test_penntreebank.py @@ -0,0 +1,75 @@ +import os +import random +import string +import tarfile +from collections import defaultdict +from unittest.mock import patch + +from parameterized import parameterized +from torchtext.datasets.penntreebank import PennTreebank + +from ..common.case_utils import TempDirMixin, zip_equal +from ..common.torchtext_test_case import TorchtextTestCase + + +def _get_mock_dataset(root_dir): + """ + root_dir: directory to the mocked dataset + """ + base_dir = os.path.join(root_dir, "PennTreebank") + os.makedirs(base_dir, exist_ok=True) + + seed = 1 + mocked_data = defaultdict(list) + for file_name in ("ptb.train.txt", "ptb.valid.txt", "ptb.test.txt"): + txt_file = os.path.join(base_dir, file_name) + with open(txt_file, "w") as f: + for i in range(5): + rand_string = " ".join( + random.choice(string.ascii_letters) for i in range(seed) + ) + dataset_line = f"{rand_string}" + # append line to correct dataset split + split = file_name.replace("ptb.", "").replace(".txt", "") + mocked_data[split].append(dataset_line) + f.write(f"{rand_string}\n") + seed += 1 + + return mocked_data + + +class TestPennTreebank(TempDirMixin, TorchtextTestCase): + root_dir = None + samples = [] + + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.root_dir = cls.get_base_temp_dir() + cls.samples = _get_mock_dataset(cls.root_dir) + cls.patcher = patch( + "torchdata.datapipes.iter.util.cacheholder._hash_check", return_value=True + ) + cls.patcher.start() + + @classmethod + def tearDownClass(cls): + cls.patcher.stop() + super().tearDownClass() + + @parameterized.expand(["train", "valid", "test"]) + def test_amazon_review_polarity(self, split): + dataset = PennTreebank(root=self.root_dir, split=split) + + samples = list(dataset) + expected_samples = self.samples[split] + for sample, expected_sample in zip_equal(samples, expected_samples): + self.assertEqual(sample, expected_sample) + + @parameterized.expand(["train", "valid", "test"]) + def test_amazon_review_polarity_split_argument(self, split): + dataset1 = PennTreebank(root=self.root_dir, split=split) + (dataset2,) = PennTreebank(root=self.root_dir, split=(split,)) + + for d1, d2 in zip_equal(dataset1, dataset2): + self.assertEqual(d1, d2) From aa131f0877c5605e0a54eb86e77634432ca0c2b6 Mon Sep 17 00:00:00 2001 From: nayef211 Date: Thu, 3 Feb 2022 19:46:17 -0800 Subject: [PATCH 2/2] Updated test names --- test/datasets/test_penntreebank.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/datasets/test_penntreebank.py b/test/datasets/test_penntreebank.py index 1468191143..fd78ecd8c4 100644 --- a/test/datasets/test_penntreebank.py +++ b/test/datasets/test_penntreebank.py @@ -58,7 +58,7 @@ def tearDownClass(cls): super().tearDownClass() @parameterized.expand(["train", "valid", "test"]) - def test_amazon_review_polarity(self, split): + def test_penn_treebank_polarity(self, split): dataset = PennTreebank(root=self.root_dir, split=split) samples = list(dataset) @@ -67,7 +67,7 @@ def test_amazon_review_polarity(self, split): self.assertEqual(sample, expected_sample) @parameterized.expand(["train", "valid", "test"]) - def test_amazon_review_polarity_split_argument(self, split): + def test_penn_treebank_split_argument(self, split): dataset1 = PennTreebank(root=self.root_dir, split=split) (dataset2,) = PennTreebank(root=self.root_dir, split=(split,))