From df3911492af16ebe234d32be4ef3f4a9a7006c41 Mon Sep 17 00:00:00 2001 From: nayef211 Date: Thu, 3 Feb 2022 18:44:27 -0800 Subject: [PATCH 1/2] added test for yahooanswer --- test/datasets/test_yahooanswers.py | 81 ++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+) create mode 100644 test/datasets/test_yahooanswers.py diff --git a/test/datasets/test_yahooanswers.py b/test/datasets/test_yahooanswers.py new file mode 100644 index 0000000000..71ddc6d373 --- /dev/null +++ b/test/datasets/test_yahooanswers.py @@ -0,0 +1,81 @@ +import os +import random +import string +import tarfile +from collections import defaultdict +from unittest.mock import patch + +from parameterized import parameterized +from torchtext.datasets.yahooanswers import YahooAnswers + +from ..common.case_utils import TempDirMixin, zip_equal +from ..common.torchtext_test_case import TorchtextTestCase + + +def _get_mock_dataset(root_dir): + """ + root_dir: directory to the mocked dataset + """ + base_dir = os.path.join(root_dir, "YahooAnswers") + temp_dataset_dir = os.path.join(base_dir, "temp_dataset_dir") + os.makedirs(temp_dataset_dir, exist_ok=True) + + seed = 1 + mocked_data = defaultdict(list) + for file_name in ("train.csv", "test.csv"): + txt_file = os.path.join(temp_dataset_dir, file_name) + with open(txt_file, "w") as f: + for i in range(5): + label = seed % 10 + 1 + rand_string = " ".join( + random.choice(string.ascii_letters) for i in range(seed) + ) + dataset_line = (label, f"{rand_string} {rand_string} {rand_string}") + # append line to correct dataset split + mocked_data[os.path.splitext(file_name)[0]].append(dataset_line) + f.write(f'"{label}","{rand_string}","{rand_string}","{rand_string}"\n') + seed += 1 + + compressed_dataset_path = os.path.join(base_dir, "yahoo_answers_csv.tar.gz") + # create tar file from dataset folder + with tarfile.open(compressed_dataset_path, "w:gz") as tar: + tar.add(temp_dataset_dir, arcname="yahoo_answers_csv") + + return mocked_data + + +class TestYahooAnswers(TempDirMixin, TorchtextTestCase): + root_dir = None + samples = [] + + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.root_dir = cls.get_base_temp_dir() + cls.samples = _get_mock_dataset(cls.root_dir) + cls.patcher = patch( + "torchdata.datapipes.iter.util.cacheholder._hash_check", return_value=True + ) + cls.patcher.start() + + @classmethod + def tearDownClass(cls): + cls.patcher.stop() + super().tearDownClass() + + @parameterized.expand(["train", "test"]) + def test_amazon_review_polarity(self, split): + dataset = YahooAnswers(root=self.root_dir, split=split) + + samples = list(dataset) + expected_samples = self.samples[split] + for sample, expected_sample in zip_equal(samples, expected_samples): + self.assertEqual(sample, expected_sample) + + @parameterized.expand(["train", "test"]) + def test_amazon_review_polarity_split_argument(self, split): + dataset1 = YahooAnswers(root=self.root_dir, split=split) + (dataset2,) = YahooAnswers(root=self.root_dir, split=(split,)) + + for d1, d2 in zip_equal(dataset1, dataset2): + self.assertEqual(d1, d2) From 3c95f365c100648dc34554b989dee2f75a9e9562 Mon Sep 17 00:00:00 2001 From: nayef211 Date: Thu, 3 Feb 2022 19:46:55 -0800 Subject: [PATCH 2/2] Updated test names --- test/datasets/test_yahooanswers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/datasets/test_yahooanswers.py b/test/datasets/test_yahooanswers.py index 71ddc6d373..30f537c28a 100644 --- a/test/datasets/test_yahooanswers.py +++ b/test/datasets/test_yahooanswers.py @@ -64,7 +64,7 @@ def tearDownClass(cls): super().tearDownClass() @parameterized.expand(["train", "test"]) - def test_amazon_review_polarity(self, split): + def test_yahoo_answers(self, split): dataset = YahooAnswers(root=self.root_dir, split=split) samples = list(dataset) @@ -73,7 +73,7 @@ def test_amazon_review_polarity(self, split): self.assertEqual(sample, expected_sample) @parameterized.expand(["train", "test"]) - def test_amazon_review_polarity_split_argument(self, split): + def test_yahoo_answers_split_argument(self, split): dataset1 = YahooAnswers(root=self.root_dir, split=split) (dataset2,) = YahooAnswers(root=self.root_dir, split=(split,))