This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Remove Python 3.6 support as it has reached EOL #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
approved these changes
Jan 5, 2022
| workflows: | ||
| build: |
Contributor
There was a problem hiding this comment.
FYI: You can use .gitattribute file to tell git that this is a generated file. That way, it will be hidden in PR by default.
https://github.com/pytorch/audio/blob/main/.gitattributes
Contributor
Author
There was a problem hiding this comment.
That's a good callout . Will send you a PR shortly!
Codecov Report
@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
+ Coverage 86.40% 86.62% +0.21%
==========================================
Files 58 58
Lines 2332 2332
==========================================
+ Hits 2015 2020 +5
+ Misses 317 312 -5
Continue to review full report at Codecov.
|
Nayef211
approved these changes
Jan 5, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.6 reached EOL last month. PyTorch core is going to do the same in pytorch/pytorch#69005. Other libraries doing the same are:
This should also fix the CircleCI failures in 3_6 conda builds