This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Fixing clang-format version to what PyTorch uses #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
approved these changes
Oct 22, 2020
Contributor
mthrok
left a comment
mthrok
left a comment
There was a problem hiding this comment.
Looks good. When CI passes, please go ahead and merge.
Contributor
Author
|
The failed tests are unrelated so we agreed with @mthrok to merge. Thanks for the quick review! |
Contributor
|
The master is broken due to the url failure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vision-2372 we fixed the clang-format version. @mthrok proposed to do the same in text.