Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Commit d49c64a

Browse files
authored
[Nova] Disable Uploads for Linux Wheels from CircleCI (#1986)
* [Nova] Disable Uploads for Linux Wheels from CircleCI * change regenerate.py to account for the build * add back py3.8 linux wheel to allow for docs_build
1 parent 85b7903 commit d49c64a

File tree

3 files changed

+9
-114
lines changed

3 files changed

+9
-114
lines changed

.circleci/config.yml

Lines changed: 0 additions & 113 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.circleci/regenerate.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ def build_workflows(prefix="", upload=False, filter_branch=None, indentation=6):
3535
if not fb and (os_type == "linux" and btype == "wheel" and python_version == "3.8"):
3636
# the fields must match the build_docs "requires" dependency
3737
fb = "/.*/"
38+
# We'll stop building Linux Wheels from CircleCI. Keeping
39+
# around the Python3.8 build just for docs builds until those
40+
# are also migrated.
41+
if os_type == "linux" and btype == "wheel" and python_version != "3.8":
42+
continue
3843
w += build_workflow_pair(btype, os_type, python_version, fb, prefix, upload)
3944

4045
if not filter_branch:
@@ -50,6 +55,9 @@ def build_workflow_pair(btype, os_type, python_version, filter_branch, prefix=""
5055
base_workflow_name = f"{prefix}binary_{os_type}_{btype}_py{python_version}"
5156
w.append(generate_base_workflow(base_workflow_name, python_version, filter_branch, os_type, btype))
5257

58+
if os_type == "linux" and btype == "wheel" and python_version == "3.8":
59+
upload = False
60+
5361
if upload:
5462
w.append(generate_upload_workflow(base_workflow_name, filter_branch, btype))
5563
if filter_branch == "nightly" and os_type in ["linux", "windows"]:

.github/workflows/build-wheels-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
smoke-test-script: ${{ matrix.smoke-test-script }}
4141
# Using "development" as trigger event so these binaries are not uploaded
4242
# to official channels yet
43-
trigger-event: development
43+
trigger-event: ${{ github.event_name }}
4444
secrets:
4545
AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID: ${{ secrets.AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID }}
4646
AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY: ${{ secrets.AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY }}

0 commit comments

Comments
 (0)