added type annotation

Author: parmeet

torchtext/data/datasets_utils.py

@@ -209,8 +209,7 @@ def _wrap_split_argument_with_fn(fn, splits):
             argspec.args[1] == "split" and
             argspec.varargs is None and
             argspec.varkw is None and
-            len(argspec.kwonlyargs) == 0 and
-            len(argspec.annotations) == 0
+            len(argspec.kwonlyargs) == 0
             ):
         raise ValueError("Internal Error: Given function {} did not adhere to standard signature.".format(fn))
 
@@ -246,10 +245,9 @@ def decorator(func):
                 argspec.args[1] == "split" and
                 argspec.varargs is None and
                 argspec.varkw is None and
-                len(argspec.kwonlyargs) == 0 and
-                len(argspec.annotations) == 0
+                len(argspec.kwonlyargs) == 0
                 ):
-            raise ValueError("Internal Error: Given function {} did not adhere to standard signature.".format(fn))
+            raise ValueError("Internal Error: Given function {} did not adhere to standard signature.".format(func))
 
         @functools.wraps(func)
         def wrapper(root=_CACHE_DIR, *args, **kwargs):

torchtext/datasets/amazonreviewpolarity.py

@@ -1,5 +1,5 @@
 from torchtext._internal.module_utils import is_module_available
-
+from typing import Union, Tuple
 if is_module_available("torchdata"):
     from torchdata.datapipes.iter import FileOpener, GDriveReader, IterableWrapper
 
@@ -34,7 +34,7 @@
 @_add_docstring_header(num_lines=NUM_LINES, num_classes=2)
 @_create_dataset_directory(dataset_name=DATASET_NAME)
 @_wrap_split_argument(("train", "test"))
-def AmazonReviewPolarity(root, split):
+def AmazonReviewPolarity(root: str, split: Union[Tuple[str], str]):
     # TODO Remove this after removing conditional dependency
     if not is_module_available("torchdata"):
         raise ModuleNotFoundError("Package `torchdata` not found. Please install following instructions at `https://github.com/pytorch/data`")