Skip to content

Commit d0970fa

Browse files
committed
Fix TORCH_CHECK macros when glog is used
Makes TORCH_CHECK_* run unconditionally, leaving only TORCH_DCHECK_* special-cased to be optimized out in release builds.
1 parent df741c5 commit d0970fa

File tree

1 file changed

+2
-19
lines changed

1 file changed

+2
-19
lines changed

c10/util/logging_is_google_glog.h

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,14 @@ INSTANTIATE_FOR_CONTAINER(set)
5050
#include <glog/logging.h>
5151

5252
// Additional macros on top of glog
53-
#ifndef NDEBUG
5453
#define TORCH_CHECK_EQ(val1, val2) CHECK_EQ(val1, val2)
5554
#define TORCH_CHECK_NE(val1, val2) CHECK_NE(val1, val2)
5655
#define TORCH_CHECK_LE(val1, val2) CHECK_LE(val1, val2)
5756
#define TORCH_CHECK_LT(val1, val2) CHECK_LT(val1, val2)
5857
#define TORCH_CHECK_GE(val1, val2) CHECK_GE(val1, val2)
5958
#define TORCH_CHECK_GT(val1, val2) CHECK_GT(val1, val2)
59+
60+
#ifndef NDEBUG
6061
#define TORCH_DCHECK_EQ(val1, val2) DCHECK_EQ(val1, val2)
6162
#define TORCH_DCHECK_NE(val1, val2) DCHECK_NE(val1, val2)
6263
#define TORCH_DCHECK_LE(val1, val2) DCHECK_LE(val1, val2)
@@ -65,24 +66,6 @@ INSTANTIATE_FOR_CONTAINER(set)
6566
#define TORCH_DCHECK_GT(val1, val2) DCHECK_GT(val1, val2)
6667
#else // !NDEBUG
6768
// These versions generate no code in optimized mode.
68-
#define TORCH_CHECK_EQ(val1, val2) \
69-
while (false) \
70-
CHECK_EQ(val1, val2)
71-
#define TORCH_CHECK_NE(val1, val2) \
72-
while (false) \
73-
CHECK_NE(val1, val2)
74-
#define TORCH_CHECK_LE(val1, val2) \
75-
while (false) \
76-
CHECK_LE(val1, val2)
77-
#define TORCH_CHECK_LT(val1, val2) \
78-
while (false) \
79-
CHECK_LT(val1, val2)
80-
#define TORCH_CHECK_GE(val1, val2) \
81-
while (false) \
82-
CHECK_GE(val1, val2)
83-
#define TORCH_CHECK_GT(val1, val2) \
84-
while (false) \
85-
CHECK_GT(val1, val2)
8669
#define TORCH_DCHECK_EQ(val1, val2) \
8770
while (false) \
8871
DCHECK_EQ(val1, val2)

0 commit comments

Comments
 (0)