Skip to content

Update torchtune pin #7670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update torchtune pin #7670

merged 1 commit into from
Jan 15, 2025

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Jan 15, 2025 •
edited
Loading

Summary

Current torchtune pin is not in the S3 bucket anymore. https://download.pytorch.org/whl/nightly/torchtune/

Updating to latest

Test

CI

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7670

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 68 Pending

As of commit 480356f with merge base 01d526f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2025
@mergennachin mergennachin mentioned this pull request Jan 15, 2025
Closed
@mergennachin mergennachin merged commit a18f6e8 into main Jan 15, 2025
103 of 109 checks passed
@mergennachin mergennachin deleted the update_torchtune_pin branch January 15, 2025 15:58
This was referenced Jan 15, 2025
Closed
Closed
jackzhxng
jackzhxng reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it not in the bucket anymore - do we evict old versions? Ideally we only update the TorchTune pin out of necessity since the test coverage for this model is not completely there yet

@mergennachin
Copy link
Contributor Author

mergennachin commented Jan 15, 2025

@dvorjackz - yeah i think we only keep like 90 days (or 60 days) in our nightlies https://download.pytorch.org/whl/nightly/torchtune/

perhaps to save on storage spaces and for maintenance.

@mergennachin
Copy link
Contributor Author

mergennachin commented Jan 16, 2025

@pytorchbot cherry-pick --onto release/0.5 -c release

pytorchbot pushed a commit that referenced this pull request Jan 16, 2025
@mergennachin @pytorchbot
Update torchtune pin (#7670)
9af7a5a 
(cherry picked from commit a18f6e8)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Jan 16, 2025

Cherry picking #7670

The cherry pick PR is at #7710 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Jan 16, 2025
Closed
This was referenced Jan 16, 2025
Closed
Closed
per pushed a commit to per/executorch that referenced this pull request Jan 16, 2025
@mergennachin @per
Update torchtune pin (pytorch#7670)
00305f0 
(cherry picked from commit a18f6e8)
mergennachin added a commit that referenced this pull request Jan 17, 2025
@mergennachin
Update torchtune pin (#7670)
875143b 
(cherry picked from commit a18f6e8)
@mergennachin mergennachin mentioned this pull request Jan 17, 2025
Merged
mergennachin added a commit that referenced this pull request Jan 17, 2025
@mergennachin @SS-JIA
Manual cherry-pick to update numpy as well as all dependencies (#7727)
5da6235 
* Install torchao by default (#7470)

Summary:

Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule.

Part of #7460

(cherry picked from commit a861294)

* Upgrade numpy version requirement to 2.0 (#7599)

Upgrade numpy version requirement to

Summary:

1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0

We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip

We had to upgrade to the latest transformers as well

(cherry picked from commit a7b5297)

* Update torchtune pin (#7670)

(cherry picked from commit a18f6e8)

* [Arm] TOSA reference model update

* Install release version of torchtune

---------

Co-authored-by: Sicheng Stephen Jia <[email protected]>
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@mergennachin @YIWENX14
Update torchtune pin (#7670)
ba3f777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackzhxng jackzhxng jackzhxng left review comments

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mergennachin @pytorchbot @ezyang @jackzhxng @facebook-github-bot