From c8cf004cd745c02810be075f564bf6c3bc521c91 Mon Sep 17 00:00:00 2001 From: gasoonjia Date: Mon, 9 Dec 2024 10:46:23 -0800 Subject: [PATCH 1/2] [dim order] reenbale dim order as default This diff reenable dim order as default feature in ExecuTorch stack. Differential Revision: [D66970153](https://our.internmc.facebook.com/intern/diff/D66970153/) [ghstack-poisoned] --- exir/capture/_config.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/exir/capture/_config.py b/exir/capture/_config.py index 24865e7a841..7f88c48ce2f 100644 --- a/exir/capture/_config.py +++ b/exir/capture/_config.py @@ -45,8 +45,7 @@ class EdgeCompileConfig: ) _skip_type_promotion: bool = False # TODO(gasoonjia): remove this - # TODO(T192537614): reenanle dim order as default - _skip_dim_order: bool = True + _skip_dim_order: bool = False @compatibility(is_backward_compatible=False) From cc7fd8a015b511f7c69c310a27d1377986164cca Mon Sep 17 00:00:00 2001 From: gasoonjia Date: Mon, 9 Dec 2024 13:52:37 -0800 Subject: [PATCH 2/2] Update on "[dim order] reenbale dim order as default" This diff reenable dim order as default feature in ExecuTorch stack. Differential Revision: [D66970153](https://our.internmc.facebook.com/intern/diff/D66970153/) [ghstack-poisoned] --- backends/vulkan/test/test_vulkan_delegate.py | 1 + 1 file changed, 1 insertion(+) diff --git a/backends/vulkan/test/test_vulkan_delegate.py b/backends/vulkan/test/test_vulkan_delegate.py index 54db1a4b778..57cbf9fa0da 100644 --- a/backends/vulkan/test/test_vulkan_delegate.py +++ b/backends/vulkan/test/test_vulkan_delegate.py @@ -122,6 +122,7 @@ def run_test(memory_layout): edge_program = to_edge_transform_and_lower( program, + compile_config=self._edge_compile_config, transform_passes=[ I64toI32(self._edge_compile_config._skip_dim_order), ],