From 9e6b78608a2a9ecbf7df69cd5278ca6dab9bf294 Mon Sep 17 00:00:00 2001 From: Vivek Trivedi Date: Thu, 8 May 2025 09:46:15 -0700 Subject: [PATCH] Minor vector sizing change. (#10753) Summary: Minor change to reserve size for VkWriteDescriptorSet and VkDescriptorSetLayoutBinding vectors. Reviewed By: SS-JIA Differential Revision: D74335276 --- backends/vulkan/runtime/vk_api/Descriptor.cpp | 5 ++--- backends/vulkan/runtime/vk_api/Shader.cpp | 3 ++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/backends/vulkan/runtime/vk_api/Descriptor.cpp b/backends/vulkan/runtime/vk_api/Descriptor.cpp index b42ade6ea02..938666802ef 100644 --- a/backends/vulkan/runtime/vk_api/Descriptor.cpp +++ b/backends/vulkan/runtime/vk_api/Descriptor.cpp @@ -154,6 +154,7 @@ DescriptorSet& DescriptorSet::bind( VkDescriptorSet DescriptorSet::get_bind_handle() const { std::vector write_descriptor_sets; + write_descriptor_sets.reserve(bindings_.size()); for (const ResourceBinding& binding : bindings_) { VkWriteDescriptorSet write{ @@ -185,9 +186,7 @@ VkDescriptorSet DescriptorSet::get_bind_handle() const { 0u, nullptr); - VkDescriptorSet ret = handle_; - - return ret; + return handle_; } void DescriptorSet::add_binding(const ResourceBinding& binding) { diff --git a/backends/vulkan/runtime/vk_api/Shader.cpp b/backends/vulkan/runtime/vk_api/Shader.cpp index e560f37868e..458b1f83956 100644 --- a/backends/vulkan/runtime/vk_api/Shader.cpp +++ b/backends/vulkan/runtime/vk_api/Shader.cpp @@ -59,10 +59,11 @@ ShaderLayout::ShaderLayout( const ShaderLayout::Signature& signature) : device_(device), handle_{VK_NULL_HANDLE} { std::vector bindings; + bindings.reserve(signature.size()); uint32_t binding_num = 0u; for (const VkDescriptorType type : signature) { - bindings.push_back({ + bindings.emplace_back(VkDescriptorSetLayoutBinding{ binding_num++, // binding type, // descriptorType 1u, // descriptorCount