Update on "[Executorch][Kernels] Build optimized lib with -O2"

Dont rely on top level config for optimization and rather set our own for optimized kernels

Differential Revision: [D64910575](https://our.internmc.facebook.com/intern/diff/D64910575/)

[ghstack-poisoned]

Author: kimishpatel

kernels/optimized/lib_defs.bzl

@@ -2,6 +2,10 @@ load("@fbsource//tools/build_defs:default_platform_defs.bzl", "DEVSERVER_PLATFOR
 load("@fbsource//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
 load("@fbsource//xplat/executorch/backends/xnnpack/third-party:third_party_libs.bzl", "third_party_dep")
 load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
+load(
+    "@fbsource//xplat/executorch/kernels/portable:op_registration_util.bzl",
+    "get_compiler_optimization_flags",
+)
 
 # Because vec exists as a collection of header files, compile and preprocessor
 # flags applied to the vec target do not have any effect, since no compilation
@@ -39,23 +43,6 @@ def get_vec_fbcode_preprocessor_flags():
     ]
     return preprocessor_flags
 
-def get_compiler_optimization_flags():
-    if not runtime.is_oss:
-      compiler_flags = select({
-        "DEFAULT": [],
-        "ovr_config//os:android-arm64": [
-              "-O2",
-        ],
-        "ovr_config//os:iphoneos": [
-            "-O2",
-        ],
-        "ovr_config//os:macos-arm64": [
-            "-O2",
-        ],
-      })
-      return compiler_flags
-    return []
-
 # Currently, having a dependency on fbsource//third-party/sleef:sleef may cause
 # duplicate symbol errors when linking fbcode targets in opt mode that also
 # depend on ATen. This is because ATen accesses sleef via the third-party folder

kernels/optimized/op_registration_util.bzl

@@ -3,6 +3,9 @@ load("@fbsource//xplat/executorch/build:selects.bzl", "selects")
 load(
     "@fbsource//xplat/executorch/kernels/optimized:lib_defs.bzl",
     "get_vec_android_preprocessor_flags",
+)
+load(
+    "@fbsource//xplat/executorch/kernels/portable:op_registration_util.bzl",
     "get_compiler_optimization_flags",
 )
 

shim/xplat/executorch/kernels/portable/op_registration_util.bzl

@@ -1,6 +1,24 @@
 load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "is_xplat", "runtime")
 load("@fbsource//xplat/executorch/build:selects.bzl", "selects")
 
+def get_compiler_optimization_flags():
+    # various ovr_configs are not available in oss
+    if not runtime.is_oss:
+      compiler_flags = select({
+        "DEFAULT": [],
+        "ovr_config//os:android-arm64": [
+              "-O2",
+        ],
+        "ovr_config//os:iphoneos": [
+            "-O2",
+        ],
+        "ovr_config//os:macos-arm64": [
+            "-O2",
+        ],
+      })
+      return compiler_flags
+    return []
+
 def op_target(name, deps = [], android_deps = [], _allow_third_party_deps = False, _aten_mode_deps = []):
     """Registers an implementation of an operator overload group.