Skip to content

Commit cb0c4c7

Browse files
authored
Merge branch 'release_validations' into fix_validations
2 parents 4d985d7 + e6b3ac5 commit cb0c4c7

20 files changed

+70
-243
lines changed

.github/scripts/validate_binaries.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,13 @@ else
1212
TEST_SUFFIX=" --package torchonly"
1313
fi
1414

15+
# if RELESE version is passed as parameter - install speific version
16+
if [[ ! -z ${RELEASE_VERSION} ]]; then
17+
INSTALLATION=${INSTALLATION/"torch "/"torch==${RELEASE_VERSION} "}
18+
INSTALLATION=${INSTALLATION/"-y pytorch "/"-y pytorch==${RELEASE_VERSION} "}
19+
INSTALLATION=${INSTALLATION/"::pytorch "/"::pytorch==${RELEASE_VERSION} "}
20+
fi
21+
1522
export OLD_PATH=${PATH}
1623
# Workaround macos-arm64 runners. Issue: https://github.com/pytorch/test-infra/issues/4342
1724
if [[ ${TARGET_OS} == 'macos-arm64' ]]; then

.github/scripts/validate_poetry.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ if [[ ! -z ${RELEASE_VERSION} ]]; then
1919
RELEASE_SUFFIX="@${RELEASE_VERSION}"
2020
fi
2121

22-
2322
if [[ ${TORCH_ONLY} == 'true' ]]; then
2423
poetry --quiet add torch${RELEASE_SUFFIX}
2524
else

aarch64_linux/aarch64_ci_setup.sh

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,17 @@ curl -L -o /mambaforge.sh https://github.com/conda-forge/miniforge/releases/late
1919
chmod +x /mambaforge.sh
2020
/mambaforge.sh -b -p /opt/conda
2121
rm /mambaforge.sh
22-
/opt/conda/bin/conda config --set ssl_verify False
23-
/opt/conda/bin/conda install -y -c conda-forge python=${DESIRED_PYTHON} numpy pyyaml setuptools patchelf pygit2 openblas ninja scons
22+
source /opt/conda/etc/profile.d/conda.sh
23+
conda config --set ssl_verify False
24+
conda create -y -c conda-forge -n aarch64_env python=${DESIRED_PYTHON}
25+
conda activate aarch64_env
26+
27+
if [[ "$DESIRED_PYTHON" == "3.8" ]]; then
28+
NUMPY_VERSION="1.24.4"
29+
else
30+
NUMPY_VERSION="1.26.0"
31+
fi
32+
conda install -y -c conda-forge numpy==${NUMPY_VERSION} pyyaml==6.0.1 patchelf==0.17.2 pygit2==1.13.2 openblas==0.3.24 ninja==1.11.1 scons==4.5.2
33+
2434
python --version
2535
conda --version

build_m1_domains.sh

Lines changed: 0 additions & 45 deletions
This file was deleted.

conda/pytorch-nightly/meta.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,20 @@ requirements:
2121
- pyyaml
2222
{% if cross_compile_arm64 == 0 %}
2323
- mkl-include # [x86_64]
24-
- mkl=2020.2 # [x86_64 and not win]
24+
- mkl=2020.2 # [py <= 311 and x86_64 and not win]
25+
- mkl=2023.1 # [py >= 312 and x86_64 and not win]
2526
- mkl=2021.4 # [x86_64 and win]
2627
{% endif %}
2728
- typing_extensions
2829
- ninja
2930
- libuv # [win]
3031
- numpy=1.19 # [py <= 39]
3132
- numpy=1.21.5 # [py == 310]
32-
- numpy=1.23.5 # [py >= 311]
33+
- numpy=1.23.5 # [py == 311]
34+
- numpy=1.26.1 # [py >= 312]
3335
- openssl=1.1.1l # [py >= 38 and py <= 310 and linux]
34-
- openssl=1.1.1s # [py >= 311 and linux]
36+
- openssl=1.1.1s # [py == 311 and linux]
37+
- openssl=3.1.4 # [py >= 312 and linux]
3538
{{ environ.get('PYTORCH_LLVM_PACKAGE', ' - llvmdev=9') }}
3639
{{ environ.get('MAGMA_PACKAGE', '') }}
3740

conda/upload.sh

Lines changed: 0 additions & 28 deletions
This file was deleted.

manywheel/build_common.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,9 @@ case ${DESIRED_PYTHON} in
131131
cp311*)
132132
retry pip install -q numpy==1.23.1
133133
;;
134+
cp312*)
135+
retry pip install -q numpy==1.26.1
136+
;;
134137
# Should catch 3.9+
135138
*)
136139
retry pip install -q numpy==1.19.4

manywheel/build_cuda.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ if [[ -n "$DESIRED_CUDA" ]]; then
4747
# There really has to be a better way to do this - eli
4848
# Possibly limiting builds to specific cuda versions be delimiting images would be a choice
4949
if [[ "$OS_NAME" == *"Ubuntu"* ]]; then
50-
echo "Switching to CUDA version $desired_cuda"
50+
echo "Switching to CUDA version ${DESIRED_CUDA}"
5151
/builder/conda/switch_cuda_version.sh "${DESIRED_CUDA}"
5252
fi
5353
else
@@ -263,7 +263,9 @@ else
263263
fi
264264

265265
# TODO: Remove me when Triton has a proper release channel
266-
if [[ $(uname) == "Linux" ]]; then
266+
# No triton dependency for now on 3.12 since we don't have binaries for it
267+
# and torch.compile doesn't work.
268+
if [[ $(uname) == "Linux" && "$DESIRED_PYTHON" != "3.12" ]]; then
267269
TRITON_SHORTHASH=$(cut -c1-10 $PYTORCH_ROOT/.github/ci_commit_pins/triton.txt)
268270

269271
if [[ -z "$PYTORCH_EXTRA_INSTALL_REQUIREMENTS" ]]; then

manywheel/build_libtorch.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ for pkg in /$LIBTORCH_HOUSE_DIR/libtorch*.zip; do
343343
fi
344344

345345
# zip up the wheel back
346-
zip -rq $(basename $pkg) $PREIX*
346+
zip -rq $(basename $pkg) $PREFIX*
347347

348348
# replace original wheel
349349
rm -f $pkg

manywheel/build_rocm.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,9 @@ if [[ $ROCM_INT -ge 50600 ]]; then
222222
fi
223223

224224
# Add triton install dependency
225-
if [[ $(uname) == "Linux" ]]; then
225+
# No triton dependency for now on 3.12 since we don't have binaries for it
226+
# and torch.compile doesn't work.
227+
if [[ $(uname) == "Linux" && "$DESIRED_PYTHON" != "3.12" ]]; then
226228
TRITON_SHORTHASH=$(cut -c1-10 $PYTORCH_ROOT/.ci/docker/ci_commit_pins/triton-rocm.txt)
227229
TRITON_VERSION=$(cat $PYTORCH_ROOT/.ci/docker/triton_version.txt)
228230

0 commit comments

Comments
 (0)