From cfbb0437c60c36843f1d81281103752f599a12d1 Mon Sep 17 00:00:00 2001 From: moto <855818+mthrok@users.noreply.github.com> Date: Thu, 10 Sep 2020 23:22:17 +0000 Subject: [PATCH 1/2] Add deprecation warning to sox backend --- torchaudio/backend/utils.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/torchaudio/backend/utils.py b/torchaudio/backend/utils.py index 84ec2fa3f5..5403202af3 100644 --- a/torchaudio/backend/utils.py +++ b/torchaudio/backend/utils.py @@ -49,6 +49,10 @@ def set_audio_backend(backend: Optional[str]): if backend is None: module = no_backend elif backend == 'sox': + warnings.warn( + '"sox" backend is deprecated. ' + 'The default backend will be changeed to "sox_io" backend in 0.8.0 and ' + '"sox" backend will be removed in 0.9.0. Please migrate to "sox_io" backend.') module = sox_backend elif backend == 'sox_io': module = sox_io_backend From f2d741b1ea230452e16c95783356a16613623892 Mon Sep 17 00:00:00 2001 From: moto <855818+mthrok@users.noreply.github.com> Date: Tue, 15 Sep 2020 11:26:19 -0700 Subject: [PATCH 2/2] Update based on the review --- torchaudio/backend/utils.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/torchaudio/backend/utils.py b/torchaudio/backend/utils.py index 5403202af3..87ec948fba 100644 --- a/torchaudio/backend/utils.py +++ b/torchaudio/backend/utils.py @@ -50,9 +50,10 @@ def set_audio_backend(backend: Optional[str]): module = no_backend elif backend == 'sox': warnings.warn( - '"sox" backend is deprecated. ' - 'The default backend will be changeed to "sox_io" backend in 0.8.0 and ' - '"sox" backend will be removed in 0.9.0. Please migrate to "sox_io" backend.') + '"sox" backend is being deprecated. ' + 'The default backend will be changed to "sox_io" backend in 0.8.0 and ' + '"sox" backend will be removed in 0.9.0. Please migrate to "sox_io" backend. ' + 'Please refer to https://github.com/pytorch/audio/issues/903 for the detail.') module = sox_backend elif backend == 'sox_io': module = sox_io_backend