Fix incorrect extension parsing #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing implementation doesn't work for FLAC.
Contributor
|
Thanks for the PR. If possible can you chery-pick mthrok@5b889af ? I added test cases for the default compression. |
Contributor
Author
|
@mthrok Done! |
Contributor
Thanks, I will merge it once it passes the tests. |
Contributor
|
I will follow up with the failing MP3 test. Thanks for the contribution! |
Contributor
|
linking to #886 |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
Tutorials Refresh - Update TOC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation doesn't work for FLAC format.