Simplify C++ registration with TORCH_LIBRARY #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 35 35
Lines 2719 2719
=======================================
Hits 2447 2447
Misses 272 272 Continue to review full report at Codecov.
|
mthrok
force-pushed
the
torch-library
branch
8 times, most recently
from
d8b8ccc to
8f4e1a1
Compare
vincentqb
approved these changes
Aug 7, 2020
Contributor
vincentqb
left a comment
vincentqb
left a comment
There was a problem hiding this comment.
LGTM! This is cleaner :)
Contributor
Author
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the raw PyTorch C++ registration mechanism with
TORCH_LIBRARYmacro.