Add cmu_arctic dataset #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentqb
suggested changes
Jun 9, 2020
torchaudio/datasets/cmu_arctic.py
Outdated
| for line in ft: | ||
| file_id, utterance = line.strip().split(" ", 2)[1:] | ||
| if fileid == file_id: | ||
| utterance = utterance[1:-3] |
Contributor
There was a problem hiding this comment.
Can you add a quick comment to document this line?
# clean "(utterance )" to "utterance"
Contributor
Author
There was a problem hiding this comment.
I will add the comment. Thanks.
torchaudio/datasets/cmu_arctic.py
Outdated
|
|
||
| class CMU_ARCTIC(Dataset): | ||
| """ | ||
| Create a Dataset for CMU_Arctic. Each item is a tuple of the form: |
Contributor
There was a problem hiding this comment.
nit: no need for underscore
Contributor
Author
There was a problem hiding this comment.
I will change it. Thanks.
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
==========================================
- Coverage 88.78% 88.72% -0.07%
==========================================
Files 22 23 +1
Lines 2355 2404 +49
==========================================
+ Hits 2091 2133 +42
- Misses 264 271 +7
Continue to review full report at Codecov.
|
Contributor
Author
|
Updates:
|
vincentqb
reviewed
Jun 10, 2020
vincentqb
reviewed
Jun 10, 2020
Contributor
Author
|
Updates:
|
vincentqb
reviewed
Jun 10, 2020
vincentqb
approved these changes
Jun 10, 2020
Contributor
vincentqb
left a comment
vincentqb
left a comment
There was a problem hiding this comment.
LGTM! Let's wait on the tests to be done, and then please feel free to merge it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the CMU_ARCTIC dataset used here.
Related to #550
Fixes #512