Skip to content

Conversation

@bhargavkathivarapu
Copy link
Contributor

@bhargavkathivarapu bhargavkathivarapu commented Jun 5, 2020

This PR migrates the below tests (#597 ) from test/test_compliance_kaldi.py to test/kaldi_compatibility_impl.py

I am migrating all minor tests in this PR, which are not dependent on other files for arguments .

  • resample accuracy
  • resample size
  • mfcc empty input check

Signed-off-by: Bhargav Kathivarapu <[email protected]>
Signed-off-by: Bhargav Kathivarapu <[email protected]>
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #699 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files          22       22           
  Lines        2338     2338           
=======================================
  Hits         2083     2083           
  Misses        255      255           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2416e5d...3599ef5. Read the comment docs.

@mthrok
Copy link
Contributor

mthrok commented Jun 5, 2020

Hi @bhargavkathivarapu

Thanks for working on this.
Let me get back to this later as, unlike the other tests we've migrated, Kaldi does not provide a simple CLI for this.
I have to study the code and come up with the right approach. I feel the existing tests require improvements.

Note:
Kaldi's implementation is found here, and the corresponding test is found here and here

@mthrok
Copy link
Contributor

mthrok commented Aug 3, 2021

We have replaced the resample module in 0.9 release and Kaldi's resample code is no longer the reference point.
Closing the issue. Thanks @bhargavkathivarapu and sorry for the unfruitful collaboration here. Please feel free to pick up an any help-wanted task in the future. Now the team behind torchaudio has grown, we should be able to better respond.

@mthrok mthrok closed this Aug 3, 2021
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
…h#699)

* dataroot parameter set to required=False

in the dcgan example

* more robust check on dcgan fake dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants