Added ability to save tensors #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
reviewed
May 27, 2017
torchaudio/__init__.py
Outdated
| func = th_sox.libthsox_Int_write_audio_file | ||
| elif isinstance(src, torch.LongTensor): | ||
| func = th_sox.libthsox_Long_write_audio_file | ||
| func(bytes(filepath), src, extension.replace('.', ''), sample_rate) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torchaudio/__init__.py
Outdated
| elif isinstance(src, torch.IntTensor): | ||
| func = th_sox.libthsox_Int_write_audio_file | ||
| elif isinstance(src, torch.LongTensor): | ||
| func = th_sox.libthsox_Long_write_audio_file |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torchaudio/__init__.py
Outdated
|
|
||
| def save(filepath, src, sample_rate): | ||
| assert torch.is_tensor(src) | ||
| assert not src.is_cuda |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
Thanks for the feedback @apaszke, made a few changes if you could review again! |
apaszke
reviewed
May 27, 2017
| audio.save( | ||
| string, # path to file | ||
| tensor, # NSamples x NChannels 2D tensor | ||
| number, # sample_rate of the audio to be saved as |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mingbowan
added a commit
that referenced
this pull request
Nov 25, 2019
* adding smoke test * adding smoke test * fix config.yml * trigger smoke test * test aws erc credential * test aws erc credential * test aws erc credential * test aws erc credential * adding ecr cred * test aws erc credential * test aws erc credential * test aws erc credential - different way * test aws erc credential - different way #2 * test aws erc credential - different way #3 * test aws erc credential - different way #4 * test aws #1 * test aws erc credential, after enabling circleci setting * fixing conda init * add verbose output for smoke test * add docker image build workflow * add docker image build workflow * fix aws ecr login * use images build from circelci * ready for review * updated Readme with instructions on nightly install, also updated docker image which can make nightlies installed via pip pass * nit * reduce size
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
Update .grad attribute type
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
Making CUDA optional for MNIST example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported the code from here to save tensors! Should also close #2, let me know if any feedback