Retrieve version from version.txt #2434
Conversation
mthrok
left a comment
mthrok
left a comment
There was a problem hiding this comment.
Could we split the PR in two?. One for changes related to version.txt and the other for other M1 changes.
packaging/pkg_helpers.bash
Outdated
| # command below yields 0.10.0 from version.txt containing 0.10.0a0 | ||
| _VERSION_BASE=$( cut -f 1 -d a "$SCRIPT_DIR/../version.txt" ) | ||
| else | ||
| _VERSION_BASE="$1" |
There was a problem hiding this comment.
Is there an existing use case for this else branch?
If not, it might introduce accidental/unexpected issue.
I think validating $# -eq 0 is more error prof.
There was a problem hiding this comment.
Yes, true we want to keep things simple and retrieve either from $BUILD_VERSION or version.txt . Made changes accordingly
Hm, I think in original M1 PR, the version was incorrect. But sure I can get the M1 changes out of this and then post another PR for M1. Its true splitting the PR seems cleaner |
atalman
changed the title
|
@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @atalman. |
3 participants
Retrieve version from version.txt
These improvement introduced in following PR: pytorch/vision#6117
In addition to this we add version.txt file to help us manage torchaudio version