From 672dc6368a46c4aaeaecffdd3b09d9a336d761da Mon Sep 17 00:00:00 2001 From: Thomas Brandon Date: Mon, 3 Jun 2019 02:42:17 +1000 Subject: [PATCH] Fix segfault passing null to sox_close --- torchaudio/torch_sox.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/torchaudio/torch_sox.cpp b/torchaudio/torch_sox.cpp index 92241dcbee..b6cc4bbb3b 100644 --- a/torchaudio/torch_sox.cpp +++ b/torchaudio/torch_sox.cpp @@ -18,7 +18,9 @@ struct SoxDescriptor { SoxDescriptor& operator=(const SoxDescriptor& other) = delete; SoxDescriptor& operator=(SoxDescriptor&& other) = delete; ~SoxDescriptor() { - sox_close(fd_); + if (fd_ != nullptr) { + sox_close(fd_); + } } sox_format_t* operator->() noexcept { return fd_;