From 63f2bdfbafead08dd0196cac2bbad51178e245a3 Mon Sep 17 00:00:00 2001 From: moto <855818+mthrok@users.noreply.github.com> Date: Mon, 17 May 2021 21:04:58 +0000 Subject: [PATCH 1/2] Fix HTTP test by changing port --- test/torchaudio_unittest/common_utils/case_utils.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/torchaudio_unittest/common_utils/case_utils.py b/test/torchaudio_unittest/common_utils/case_utils.py index 773f1915b9..10924bdfe8 100644 --- a/test/torchaudio_unittest/common_utils/case_utils.py +++ b/test/torchaudio_unittest/common_utils/case_utils.py @@ -52,14 +52,15 @@ class HttpServerMixin(TempDirMixin): The server is up through the execution of all the test suite defined under the subclass. """ _proc = None - _port = 8000 + _port = 20576 @classmethod def setUpClass(cls): super().setUpClass() cls._proc = subprocess.Popen( ['python', '-m', 'http.server', f'{cls._port}'], - cwd=cls.get_base_temp_dir()) + cwd=cls.get_base_temp_dir(), + stderr=subprocess.DEVNULL) # Disable server-side error log because it is confusing time.sleep(1.0) @classmethod From 5c36dd628aac1fdf02318ffbda89ba5a6f821b47 Mon Sep 17 00:00:00 2001 From: moto <855818+mthrok@users.noreply.github.com> Date: Tue, 18 May 2021 23:23:44 +0000 Subject: [PATCH 2/2] revert port change and increase startup wait time to 2 --- test/torchaudio_unittest/common_utils/case_utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/torchaudio_unittest/common_utils/case_utils.py b/test/torchaudio_unittest/common_utils/case_utils.py index 10924bdfe8..fa3d5077bb 100644 --- a/test/torchaudio_unittest/common_utils/case_utils.py +++ b/test/torchaudio_unittest/common_utils/case_utils.py @@ -52,7 +52,7 @@ class HttpServerMixin(TempDirMixin): The server is up through the execution of all the test suite defined under the subclass. """ _proc = None - _port = 20576 + _port = 8000 @classmethod def setUpClass(cls): @@ -61,7 +61,7 @@ def setUpClass(cls): ['python', '-m', 'http.server', f'{cls._port}'], cwd=cls.get_base_temp_dir(), stderr=subprocess.DEVNULL) # Disable server-side error log because it is confusing - time.sleep(1.0) + time.sleep(2.0) @classmethod def tearDownClass(cls):