Address PR feedbacks

Author: mthrok

torchaudio/backend/sox_io_backend.py

@@ -87,8 +87,9 @@ def load(
         filepath (path-like object or file-like object):
             Source of audio data. When the function is not compiled by TorchScript,
             (e.g. ``torch.jit.script``), the following types are accepted;
-                  * ``path-like object``: file path
-                  * ``file-like object``: Any object with ``read`` method that returns ``bytes``.
+                  * ``path-like``: file path
+                  * ``file-like``: Object with ``read(size: int) -> bytes`` method,
+                    which returns byte string of at most ``size`` length.
             When the function is compiled by TorchScript, only ``str`` type is allowed.
 
             Note:

torchaudio/csrc/sox/effects.cpp

@@ -178,7 +178,7 @@ std::tuple<torch::Tensor, int64_t> apply_effects_fileobj(
       /*signal=*/nullptr,
       /*encoding=*/nullptr,
       /*filetype=*/format.has_value() ? format.value().c_str() : nullptr));
-  validate_input_file(sf);
+  validate_input_file(sf, /*check_length=*/false);
 
   const auto dtype = get_dtype(sf->encoding.encoding, sf->signal.precision);
 

torchaudio/csrc/sox/effects_chain.cpp

@@ -198,7 +198,7 @@ void SoxEffectsChain::addInputTensor(TensorSignal* signal) {
   priv->signal = signal;
   priv->index = 0;
   if (sox_add_effect(sec_, e, &interm_sig_, &in_sig_) != SOX_SUCCESS) {
-    throw std::runtime_error("Failed to add effect: input_tensor");
+    throw std::runtime_error("Internal Error: Failed to add effect: input_tensor");
   }
 }
 
@@ -207,7 +207,7 @@ void SoxEffectsChain::addOutputBuffer(
   SoxEffect e(sox_create_effect(get_tensor_output_handler()));
   static_cast<TensorOutputPriv*>(e->priv)->buffer = output_buffer;
   if (sox_add_effect(sec_, e, &interm_sig_, &in_sig_) != SOX_SUCCESS) {
-    throw std::runtime_error("Failed to add effect: output_tensor");
+    throw std::runtime_error("Internal Error: Failed to add effect: output_tensor");
   }
 }
 
@@ -219,7 +219,7 @@ void SoxEffectsChain::addInputFile(sox_format_t* sf) {
   sox_effect_options(e, 1, opts);
   if (sox_add_effect(sec_, e, &interm_sig_, &in_sig_) != SOX_SUCCESS) {
     std::ostringstream stream;
-    stream << "Failed to add effect: input " << sf->filename;
+    stream << "Internal Error: Failed to add effect: input " << sf->filename;
     throw std::runtime_error(stream.str());
   }
 }
@@ -230,7 +230,7 @@ void SoxEffectsChain::addOutputFile(sox_format_t* sf) {
   static_cast<FileOutputPriv*>(e->priv)->sf = sf;
   if (sox_add_effect(sec_, e, &interm_sig_, &out_sig_) != SOX_SUCCESS) {
     std::ostringstream stream;
-    stream << "Failed to add effect: output " << sf->filename;
+    stream << "Internal Error: Failed to add effect: output " << sf->filename;
     throw std::runtime_error(stream.str());
   }
 }
@@ -266,7 +266,7 @@ void SoxEffectsChain::addEffect(const std::vector<std::string> effect) {
 
   if (sox_add_effect(sec_, e, &interm_sig_, &in_sig_) != SOX_SUCCESS) {
     std::ostringstream stream;
-    stream << "Failed to add effect: \"" << name;
+    stream << "Internal Error: Failed to add effect: \"" << name;
     for (size_t i = 1; i < num_args; ++i) {
       stream << " " << effect[i];
     }
@@ -403,7 +403,7 @@ void SoxEffectsChain::addInputFileObj(
   priv->buffer = buffer;
   priv->buffer_size = buffer_size;
   if (sox_add_effect(sec_, e, &interm_sig_, &in_sig_) != SOX_SUCCESS) {
-    throw std::runtime_error("Failed to add effect: input fileobj");
+    throw std::runtime_error("Internal Error: Failed to add effect: input fileobj");
   }
 }
 

torchaudio/csrc/sox/utils.cpp

@@ -92,13 +92,17 @@ SoxFormat::operator sox_format_t*() const noexcept {
   return fd_;
 }
 
-void validate_input_file(const SoxFormat& sf) {
+void validate_input_file(const SoxFormat& sf, bool check_length) {
   if (static_cast<sox_format_t*>(sf) == nullptr) {
     throw std::runtime_error("Error loading audio file: failed to open file.");
   }
   if (sf->encoding.encoding == SOX_ENCODING_UNKNOWN) {
     throw std::runtime_error("Error loading audio file: unknown encoding.");
   }
+
+  if (check_length && sf->signal.length == 0) {
+    throw std::runtime_error("Error reading audio file: unknown length.");
+  }
 }
 
 void validate_input_tensor(const torch::Tensor tensor) {

torchaudio/csrc/sox/utils.h

@@ -67,7 +67,7 @@ struct SoxFormat {
 
 ///
 /// Verify that input file is found, has known encoding, and not empty
-void validate_input_file(const SoxFormat& sf);
+void validate_input_file(const SoxFormat& sf, bool check_length=true);
 
 ///
 /// Verify that input Tensor is 2D, CPU and either uin8, int16, int32 or float32