Enable ABI suffix for extension module

mthrok · mthrok · commit ec108a113981 · 2020-07-31T14:54:54.000Z
When installing torchaudio from source `python setup.py install` performs
egg (zip) installation. This causes confusion when building from source for
multiple environments with different Python versions, as `_torchaudio.so`
does not have Python ABI version in its name and importlib cannot find it.

This change fixs this by enableing ABI extension.

squash! Enable ABI suffix for extension module
diff --git a/setup.py b/setup.py
@@ -83,7 +83,7 @@ def run(self):
     packages=find_packages(exclude=["build*", "test*", "torchaudio.csrc*", "third_party*", "build_tools*"]),
     ext_modules=setup_helpers.get_ext_modules(),
     cmdclass={
-        'build_ext': setup_helpers.BuildExtension.with_options(no_python_abi_suffix=True)
+        'build_ext': setup_helpers.BuildExtension,
     },
     install_requires=[pytorch_package_dep]
 )

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ def run(self):`
`83`	`83`	`packages=find_packages(exclude=["build", "test", "torchaudio.csrc", "third_party", "build_tools*"]),`
`84`	`84`	`ext_modules=setup_helpers.get_ext_modules(),`
`85`	`85`	`cmdclass={`
`86`		`- 'build_ext': setup_helpers.BuildExtension.with_options(no_python_abi_suffix=True)`
	`86`	`+ 'build_ext': setup_helpers.BuildExtension,`
`87`	`87`	`},`
`88`	`88`	`install_requires=[pytorch_package_dep]`
`89`	`89`	`)`