Skip to content

Commit 80bfb28

Browse files
authored
Bake libsox in test base Docker image (#739)
In #728, linux unit test switches to libsox provided by apt. For CPU jobs this is fine because all the job steps share the same Docker container, but on CPU job, each job step runs a script in a new Docker container, so libsox installed in a step is not available to the subsequent steps. To fix this, this PR moves the installation of libsox and sox to Docker build.
1 parent d9e6ce4 commit 80bfb28

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.circleci/unittest/linux/docker/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ RUN apt update && apt install -y \
5555
curl \
5656
make \
5757
file \
58+
sox \
59+
libsox-dev \
60+
libsox-fmt-all \
5861
&& rm -rf /var/lib/apt/lists/*
5962
COPY --from=builder /kaldi /kaldi
6063
COPY --from=builder /third_party /third_party

.circleci/unittest/linux/scripts/setup_env.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,3 @@ conda env update --file "${this_dir}/environment.yml" --prune
3535

3636
# 4. Build codecs
3737
# build_tools/setup_helpers/build_third_party.sh
38-
# 4. Install codecs
39-
apt update -q
40-
apt install -y -q sox libsox-dev libsox-fmt-all

0 commit comments

Comments
 (0)