Skip to content

Commit 17ee9d0

Browse files
q10facebook-github-bot
authored andcommitted
Misc CI fixes (#4813)
Summary: X-link: facebookresearch/FBGEMM#1842 - Increased timeout for Nova genai aarch64 jobs - Disable `test_backward_sgd_writeback` on GitHub + ROCm for now bc it is flaky Pull Request resolved: #4813 Reviewed By: cthi Differential Revision: D81604499 Pulled By: q10 fbshipit-source-id: 5f67627945b4235e3e750c6838f41305fe39d038
1 parent c43677d commit 17ee9d0

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

.github/workflows/build_wheels_genai_linux_aarch64.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,4 +88,4 @@ jobs:
8888
trigger-event: ${{ github.event_name }}
8989
architecture: aarch64
9090
setup-miniconda: false
91-
timeout: 150
91+
timeout: 210

fbgemm_gpu/test/tbe/training/backward_none_test.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,15 @@
4848
additional_decorators,
4949
gpu_unavailable,
5050
optests,
51+
running_on_github,
5152
TEST_WITH_ROCM,
5253
)
5354
else:
5455
from fbgemm_gpu.test.test_utils import (
5556
additional_decorators,
5657
gpu_unavailable,
5758
optests,
59+
running_on_github,
5860
TEST_WITH_ROCM,
5961
)
6062
VERBOSITY: Verbosity = Verbosity.verbose
@@ -84,7 +86,10 @@
8486
@optests.generate_opcheck_tests(fast=True, additional_decorators=additional_decorators)
8587
class BackwardNoneTest(unittest.TestCase):
8688
@unittest.skipIf(*gpu_unavailable)
87-
@unittest.skipIf(torch.version.hip is not None, "Test is flaky on ROCm")
89+
@unittest.skipIf(
90+
running_on_github and torch.version.hip is not None,
91+
"Test is flaky on GitHub + ROCm",
92+
)
8893
@given(
8994
T=st.integers(min_value=1, max_value=5),
9095
D=st.integers(min_value=2, max_value=256),

fbgemm_gpu/test/tbe/training/backward_sgd_test.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
additional_decorators,
4949
gpu_unavailable,
5050
optests,
51+
running_on_github,
5152
TEST_WITH_ROCM,
5253
use_cpu_strategy,
5354
)
@@ -56,6 +57,7 @@
5657
additional_decorators,
5758
gpu_unavailable,
5859
optests,
60+
running_on_github,
5961
TEST_WITH_ROCM,
6062
use_cpu_strategy,
6163
)
@@ -540,6 +542,10 @@ def test_backward_sgd_really_long_segments( # noqa C901
540542
SparseType.FP32, # output_dtype
541543
)
542544

545+
@unittest.skipIf(
546+
running_on_github and torch.version.hip is not None,
547+
"Test is flaky on GitHub + ROCm",
548+
)
543549
@given(
544550
T=st.integers(min_value=1, max_value=3),
545551
D=st.integers(min_value=2, max_value=256),

0 commit comments

Comments
 (0)