Rename force_preemptive to opportunistic_auth

Signed-off-by: Robbie Harwood <[email protected]>

Author: frozencemetery

requests_gssapi/compat.py

@@ -27,7 +27,7 @@ def __init__(self, mutual_authentication=REQUIRED, service="HTTP",
             mutual_authentication=mutual_authentication,
             service=service,
             delegate=delegate,
-            force_preemptive=force_preemptive,
+            opportunistic_auth=force_preemptive,
             principal=principal,
             hostname_override=hostname_override,
             sanitize_mutual_error_response=sanitize_mutual_error_response)

requests_gssapi/gssapi_.py

@@ -81,14 +81,14 @@ def _negotiate_value(response):
 class HTTPSPNEGOAuth(AuthBase):
     """Attaches HTTP GSSAPI Authentication to the given Request object."""
     def __init__(self, mutual_authentication=REQUIRED, service="HTTP",
-                 delegate=False, force_preemptive=False, principal=None,
+                 delegate=False, opportunistic_auth=False, principal=None,
                  hostname_override=None, sanitize_mutual_error_response=True):
         self.context = {}
         self.mutual_authentication = mutual_authentication
         self.delegate = delegate
         self.pos = None
         self.service = service
-        self.force_preemptive = force_preemptive
+        self.opportunistic_auth = opportunistic_auth
         self.principal = principal
         self.hostname_override = hostname_override
         self.sanitize_mutual_error_response = sanitize_mutual_error_response
@@ -283,7 +283,7 @@ def deregister(self, response):
         response.request.deregister_hook('response', self.handle_response)
 
     def __call__(self, request):
-        if self.force_preemptive:
+        if self.opportunistic_auth:
             # add Authorization header before we receive a 401
             # by the 401 handler
             host = urlparse(request.url).hostname

test_requests_gssapi.py

@@ -560,6 +560,19 @@ def test_realm_override(self):
                 usage="initiate", flags=gssflags, creds=None)
             fake_resp.assert_called_with("token")
 
+    def test_opportunistic_auth(self):
+        with patch.multiple("gssapi.SecurityContext", __init__=fake_init,
+                            step=fake_resp):
+            auth = requests_gssapi.HTTPSPNEGOAuth(opportunistic_auth=True)
+
+            request = requests.Request(url="http://www.example.org")
+
+            auth.__call__(request)
+
+            self.assertTrue('Authorization' in request.headers)
+            self.assertEqual(request.headers.get('Authorization'),
+                             'Negotiate GSSRESPONSE')
+
 
 if __name__ == '__main__':
     unittest.main()