Skip to content

Conversation

@jborean93
Copy link
Contributor

Adds support for GSS_C_DELEG_POLICY_FLAG and some docs around it. Currently verifying the behaviour on MIT before finalising the commit message and docs.

Fixes #132

@jborean93
Copy link
Contributor Author

Have tested the behaviour of this flag and have documented the results at https://gist.github.com/jborean93/cdc6cef5e7540ade39912ca08020706b. Waiting on some further info before updating the docs #218 (comment).

@jborean93 jborean93 marked this pull request as ready for review July 12, 2020 11:18
@jborean93
Copy link
Contributor Author

@frozencemetery sorry for the false alarm, turns out MIT does act the same as Heimdal I must have done something wrong in my tests. The PR is ready for review.

I ended up calling the RequirementFlag ok_as_delegate as that matches the name in RFC4120 rather than the name of the GSSAPI macro name which is more a software implementation detail.

Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add another commit cleaning up our requirements during merge.

@frozencemetery frozencemetery merged commit 45d4817 into pythongssapi:master Jul 14, 2020
@jborean93 jborean93 deleted the ok_as_delegate branch July 14, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for GSS_C_DELEG_POLICY_FLAG

2 participants