Skip to content

Add more tests for ABC behaviour of typing classes #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2016
Merged

Add more tests for ABC behaviour of typing classes #294

merged 2 commits into from
Oct 9, 2016

Conversation

@ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented Oct 9, 2016

@gvanrossum
Here I am adding tests as discussed with @bintoro.

These tests actually revealed three small bugs:

  • Old style classes in Python don't have __mro__.
  • We should use __extra__ instead of extra in Python2 (since no kwargs in classes).
  • We should allow overriding __subclasshook__ by subclasses.

@gvanrossum gvanrossum merged commit 126d3be into python:master Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilevkivskyi @gvanrossum