Skip to content

Fix Any subclassing in setuptools #9460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix Any subclassing in setuptools #9460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stubs/setuptools/METADATA.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
version = "65.6.*"
requires = ["types-docutils"]
7 changes: 3 additions & 4 deletions stubs/setuptools/setuptools/_distutils/command/check.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
from typing import Any
from typing_extensions import TypeAlias

from ..cmd import Command
import docutils.utils

_Reporter: TypeAlias = Any # really docutils.utils.Reporter
from ..cmd import Command

# Only defined if docutils is installed.
Copy link
Collaborator

@hauntsaninja hauntsaninja Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this comment

Copy link
Collaborator Author

@Avasam Avasam Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is still true. I think it has value if someone wonders why its in the stub but not in their runtime.

class SilentReporter(_Reporter):
class SilentReporter(docutils.utils.Reporter):
messages: Any
def __init__(
self,
Expand Down