os.get_terminal_size also exists on Windows #2338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... at least according to https://docs.python.org/3/library/os.html#os.get_terminal_size. Related to python/mypy#5370.
Contributor
|
Oh lol, you beat me to it. I guess I should have checked my email before trying to write my own PR for this :) |
Contributor
|
@JelleZijlstra -- I think this is ready to be merged in? |
Member
Author
|
I try not to merge my own PRs. :) If you approve it it should be OK though. |
Michael0x2a
approved these changes
Jul 18, 2018
Contributor
|
Oh, I didn't realize I had permissions to do that -- done. |
Member
Author
|
You can always leave a review on any pull request. it shows up as green only if you have commit access to the repo though. You don't have commit access to typeshed but I'm pretty sure you know what you're doing, so in this case I think your review is sufficient. |
Member
|
I'll just add Michael as a committer!
|
Contributor
|
Neat, thanks! |
Michael0x2a
added a commit
to Michael0x2a/mypy
that referenced
this pull request
Jul 18, 2018
This is mostly so we can get python/typeshed#2338, which unblocks python#5370.
Michael0x2a
added a commit
to python/mypy
that referenced
this pull request
Jul 18, 2018
This is mostly so we can get python/typeshed#2338, which unblocks #5370.
Michael0x2a
added a commit
to Michael0x2a/mypy
that referenced
this pull request
Jul 20, 2018
This is mostly so we can get python/typeshed#2338, which unblocks python#5370.
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
... at least according to https://docs.python.org/3/library/os.html#os.get_terminal_size. Related to python/mypy#5370.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... at least according to https://docs.python.org/3/library/os.html#os.get_terminal_size.
Related to python/mypy#5370.