Skip to content

Conversation

@jablonskidev
Copy link
Contributor

@jablonskidev jablonskidev commented Oct 14, 2023

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

📚 Documentation preview 📚: https://pep-previews--3489.org.readthedocs.build/pep-0732/

@jablonskidev jablonskidev requested a review from a team as a code owner October 14, 2023 14:00
@hugovk
Copy link
Member

hugovk commented Oct 14, 2023

Please use PEP number 732. 📚

@hugovk hugovk changed the title Editorial Board PEP PEP 732: The Python Documentation Editorial Board Oct 16, 2023
@encukou encukou added the new-pep A new draft PEP submitted for initial review label Oct 18, 2023
@jablonskidev
Copy link
Contributor Author

Thank you for your feedback and patience. The PEP now has the correct number and date. I also changed "DevGuide" to "devguide" to follow house style. Please let me know if you need any further action from me.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we're almost there.

Please also update the .github/CODEOWNERS file with:

peps/pep-0732.*    @Mariatta

@jablonskidev
Copy link
Contributor Author

I applied your feedback. Please let me know if you need anything else.

Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finishing touches :)

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk merged commit 54b14ed into python:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants