Skip to content

Enable whole-file # type: ignore comments in Python 2.7. #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Enable whole-file # type: ignore comments in Python 2.7. #7789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb36d11
Add failing regression test.
brandtbucher Oct 24, 2019
4b7f667
Fix whole-file ignores on Python 2.7.
brandtbucher Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/fastparse2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def visit_Module(self, mod: ast27.Module) -> MypyFile:
self.type_ignores[ti.lineno] = parsed
else:
self.fail(INVALID_TYPE_IGNORE, ti.lineno, -1)
body = self.fix_function_overloads(self.translate_stmt_list(mod.body))
body = self.fix_function_overloads(self.translate_stmt_list(mod.body, module=True))
return MypyFile(body,
self.imports,
False,
Expand Down
5 changes: 5 additions & 0 deletions test-data/unit/check-ignore.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,11 @@ IGNORE
# type: ignore
import MISSING

[case testIgnoreWholeModulePy27]
# flags: --python-version 2.7
# type: ignore
IGNORE

[case testDontIgnoreWholeModule1]
if True:
# type: ignore
Expand Down