Skip to content

Add __match_args__ to dataclasses with no fields #15749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Add __match_args__ to dataclasses with no fields #15749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abef13e
Add failing test
hamdanal Jul 22, 2023
88c4efd
Fix empty dataclass __match_args__
hamdanal Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mypy/plugins/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,6 @@ def transform(self) -> bool:
and (
"__match_args__" not in info.names or info.names["__match_args__"].plugin_generated
)
and attributes
and py_version >= (3, 10)
):
str_type = self._api.named_type("builtins.str")
Expand Down
5 changes: 5 additions & 0 deletions test-data/unit/check-dataclasses.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1892,6 +1892,11 @@ class Two:
bar: int
t: Two
reveal_type(t.__match_args__) # N: Revealed type is "Tuple[Literal['bar']]"
@dataclass
class Empty:
...
e: Empty
reveal_type(e.__match_args__) # N: Revealed type is "Tuple[]"
[builtins fixtures/dataclasses.pyi]

[case testDataclassWithoutMatchArgs]
Expand Down