Skip to content

SubtypeVisitor: treat ParamSpec as if it was a covariant TypeVar #12096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

SubtypeVisitor: treat ParamSpec as if it was a covariant TypeVar #12096

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
442ecca
SubtypeVisitor: treat ParamSpec as if it was a covariant TypeVar
Akuli Jan 29, 2022
da5adc9
Merge remote-tracking branch 'origin/master' into paramspec
Akuli Apr 9, 2022
272de9a
use is_equivalent for everything except TypeVar and ParamSpec
Akuli Apr 9, 2022
2eb0fcc
delete test added in separate pr
Akuli Apr 10, 2022
2f7e0ee
Merge remote-tracking branch 'origin/master' into paramspec
Akuli Apr 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mypy/subtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,12 @@ def visit_instance(self, left: Instance) -> bool:
if isinstance(tvar, TypeVarType):
if not self.check_type_parameter(lefta, righta, tvar.variance):
nominal = False
else:
elif isinstance(tvar, ParamSpecType):
if not self.check_type_parameter(lefta, righta, COVARIANT):
nominal = False
else:
if not is_equivalent(lefta, righta):
nominal = False
if nominal:
TypeState.record_subtype_cache_entry(self._subtype_kind, left, right)
return nominal
Expand Down