Skip to content

Commit 6fc602e

Browse files
committed
Do not display __eq__ note when not function definition
1 parent 9854898 commit 6fc602e

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

mypy/checker.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1476,10 +1476,9 @@ def check_override(self, override: FunctionLike, original: FunctionLike,
14761476
# are erased, then it is definitely an incompatibility.
14771477

14781478
override_ids = override.type_var_ids()
1479+
type_name = None
14791480
if isinstance(override.definition, FuncDef):
14801481
type_name = override.definition.info.name()
1481-
else:
1482-
type_name = "Foo"
14831482

14841483
def erase_override(t: Type) -> Type:
14851484
return erase_typevars(t, ids_to_erase=override_ids)

mypy/messages.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -863,13 +863,13 @@ def signature_incompatible_with_supertype(
863863
name, target), context)
864864

865865
def argument_incompatible_with_supertype(
866-
self, arg_num: int, name: str, type_name: str,
866+
self, arg_num: int, name: str, type_name: Optional[str],
867867
name_in_supertype: str, supertype: str, context: Context) -> None:
868868
target = self.override_target(name, name_in_supertype, supertype)
869869
self.fail('Argument {} of "{}" incompatible with {}'
870870
.format(arg_num, name, target), context)
871871

872-
if name == "__eq__":
872+
if name == "__eq__" and type_name:
873873
multiline_msg = self.comparison_method_example_msg(class_name=type_name)
874874
self.note_multiline(multiline_msg, context)
875875

0 commit comments

Comments
 (0)