Capitalize unused type ignore message, for consistency (#11569)

Author: JukkaL

mypy/errors.py

@@ -478,7 +478,7 @@ def generate_unused_ignore_errors(self, file: str) -> None:
                 unused_codes_message = ""
                 if len(ignored_codes) > 1 and len(unused_ignored_codes) > 0:
                     unused_codes_message = f"[{', '.join(sorted(unused_ignored_codes))}]"
-                message = f'unused "type: ignore{unused_codes_message}" comment'
+                message = f'Unused "type: ignore{unused_codes_message}" comment'
                 # Don't use report since add_error_info will ignore the error!
                 info = ErrorInfo(self.import_context(), file, self.current_module(), None,
                                  None, line, -1, 'error', message,

test-data/unit/check-errorcodes.test

@@ -113,27 +113,27 @@ b = 'x'.foobar(b) # type: int # type: ignore[name-defined, xyz]  # E: "str" has
 
 [case testErrorCodeWarnUnusedIgnores1]
 # flags: --warn-unused-ignores
-x # type: ignore[name-defined, attr-defined] # E: unused "type: ignore[attr-defined]" comment
+x # type: ignore[name-defined, attr-defined] # E: Unused "type: ignore[attr-defined]" comment
 
 [case testErrorCodeWarnUnusedIgnores2]
 # flags: --warn-unused-ignores
 "x".foobar(y) # type: ignore[name-defined, attr-defined]
 
 [case testErrorCodeWarnUnusedIgnores3]
 # flags: --warn-unused-ignores
-"x".foobar(y) # type: ignore[name-defined, attr-defined, xyz] # E: unused "type: ignore[xyz]" comment
+"x".foobar(y) # type: ignore[name-defined, attr-defined, xyz] # E: Unused "type: ignore[xyz]" comment
 
 [case testErrorCodeWarnUnusedIgnores4]
 # flags: --warn-unused-ignores
-"x".foobar(y) # type: ignore[name-defined, attr-defined, valid-type] # E: unused "type: ignore[valid-type]" comment
+"x".foobar(y) # type: ignore[name-defined, attr-defined, valid-type] # E: Unused "type: ignore[valid-type]" comment
 
 [case testErrorCodeWarnUnusedIgnores5]
 # flags: --warn-unused-ignores
-"x".foobar(y) # type: ignore[name-defined, attr-defined, valid-type, xyz] # E: unused "type: ignore[valid-type, xyz]" comment
+"x".foobar(y) # type: ignore[name-defined, attr-defined, valid-type, xyz] # E: Unused "type: ignore[valid-type, xyz]" comment
 
 [case testErrorCodeWarnUnusedIgnores6_NoDetailWhenSingleErrorCode]
 # flags: --warn-unused-ignores
-"x" # type: ignore[name-defined] # E: unused "type: ignore" comment
+"x" # type: ignore[name-defined] # E: Unused "type: ignore" comment
 
 [case testErrorCodeIgnoreWithExtraSpace]
 x  # type: ignore   [name-defined]

test-data/unit/check-ignore.test

@@ -222,7 +222,7 @@ yield  # type: ignore  # E: "yield" outside function
 [case testIgnoreWholeModule1]
 # flags: --warn-unused-ignores
 # type: ignore
-IGNORE # type: ignore  # E: unused "type: ignore" comment
+IGNORE # type: ignore  # E: Unused "type: ignore" comment
 
 [case testIgnoreWholeModule2]
 # type: ignore

test-data/unit/check-incremental.test

@@ -3671,7 +3671,7 @@ pass
 [out]
 [out2]
 [out3]
-tmp/a.py:2: error: unused "type: ignore" comment
+tmp/a.py:2: error: Unused "type: ignore" comment
 
 -- Test that a non cache_fine_grained run can use a fine-grained cache
 [case testRegularUsesFgCache]

test-data/unit/check-python38.test

@@ -18,7 +18,7 @@ def f(): ...  # E: Function is missing a return type annotation \
 def d(f): ...  # type: ignore
 @d
 # type: ignore
-def f(): ...  # type: ignore  # E: unused "type: ignore" comment
+def f(): ...  # type: ignore  # E: Unused "type: ignore" comment
 
 [case testIgnoreDecoratedFunction2]
 # flags: --disallow-untyped-defs
@@ -91,28 +91,28 @@ def g(x: int): ...
 
 [case testIgnoreScopeUnused1]
 # flags: --warn-unused-ignores
-(  # type: ignore  # E: unused "type: ignore" comment
-    "IGNORE"  # type: ignore  # E: unused "type: ignore" comment
-    +  # type: ignore  # E: unused "type: ignore" comment
+(  # type: ignore  # E: Unused "type: ignore" comment
+    "IGNORE"  # type: ignore  # E: Unused "type: ignore" comment
+    +  # type: ignore  # E: Unused "type: ignore" comment
     0  # type: ignore
-)  # type: ignore  # E: unused "type: ignore" comment
+)  # type: ignore  # E: Unused "type: ignore" comment
 [builtins fixtures/primitives.pyi]
 
 [case testIgnoreScopeUnused2]
 # flags: --warn-unused-ignores
-(  # type: ignore  # E: unused "type: ignore" comment
+(  # type: ignore  # E: Unused "type: ignore" comment
     "IGNORE"
     -  # type: ignore
-    0  # type: ignore  # E: unused "type: ignore" comment
-)  # type: ignore  # E: unused "type: ignore" comment
+    0  # type: ignore  # E: Unused "type: ignore" comment
+)  # type: ignore  # E: Unused "type: ignore" comment
 
 [case testIgnoreScopeUnused3]
 # flags: --warn-unused-ignores
-(  # type: ignore  # E: unused "type: ignore" comment
+(  # type: ignore  # E: Unused "type: ignore" comment
     "IGNORE"
     /
     0  # type: ignore
-)  # type: ignore  # E: unused "type: ignore" comment
+)  # type: ignore  # E: Unused "type: ignore" comment
 
 [case testPEP570ArgTypesMissing]
 # flags: --disallow-untyped-defs

test-data/unit/check-warnings.test

@@ -51,7 +51,7 @@ a = 1
 if int():
     a = 'a' # type: ignore
 if int():
-    a = 2 # type: ignore # E: unused "type: ignore" comment
+    a = 2 # type: ignore # E: Unused "type: ignore" comment
 if int():
     a = 'b' # E: Incompatible types in assignment (expression has type "str", variable has type "int")
 
@@ -63,8 +63,8 @@ from m import * # type: ignore
 [file m.py]
 pass
 [out]
-main:3: error: unused "type: ignore" comment
-main:4: error: unused "type: ignore" comment
+main:3: error: Unused "type: ignore" comment
+main:4: error: Unused "type: ignore" comment
 
 
 -- No return