Skip to content

Commit 260ac5f

Browse files
authored
[mypyc] Remove c_ prefix in primitive registry (#9725)
relates mypyc/mypyc#781 remove the c_ prefix since we no longer have the old registry.
1 parent 6272beb commit 260ac5f

File tree

14 files changed

+267
-268
lines changed

14 files changed

+267
-268
lines changed

mypyc/irbuild/builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
)
4444
from mypyc.ir.func_ir import FuncIR, INVALID_FUNC_DEF
4545
from mypyc.ir.class_ir import ClassIR, NonExtClassInfo
46-
from mypyc.primitives.registry import CFunctionDescription, c_function_ops
46+
from mypyc.primitives.registry import CFunctionDescription, function_ops
4747
from mypyc.primitives.list_ops import to_list, list_pop_last
4848
from mypyc.primitives.dict_ops import dict_get_item_op, dict_set_item_op
4949
from mypyc.primitives.generic_ops import py_setattr_op, iter_op, next_op
@@ -755,7 +755,7 @@ def call_refexpr_with_args(
755755

756756
# Handle data-driven special-cased primitive call ops.
757757
if callee.fullname is not None and expr.arg_kinds == [ARG_POS] * len(arg_values):
758-
call_c_ops_candidates = c_function_ops.get(callee.fullname, [])
758+
call_c_ops_candidates = function_ops.get(callee.fullname, [])
759759
target = self.builder.matching_call_c(call_c_ops_candidates, arg_values,
760760
expr.line, self.node_type(expr))
761761
if target:

mypyc/irbuild/ll_builder.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
STATIC_PREFIX, PLATFORM_SIZE
4040
)
4141
from mypyc.primitives.registry import (
42-
c_method_call_ops, CFunctionDescription, c_function_ops,
43-
c_binary_ops, c_unary_ops, ERR_NEG_INT
42+
method_call_ops, CFunctionDescription, function_ops,
43+
binary_ops, unary_ops, ERR_NEG_INT
4444
)
4545
from mypyc.primitives.list_ops import (
4646
list_extend_op, new_list_op
@@ -542,7 +542,7 @@ def binary_op(self,
542542
'&', '&=', '|', '|=', '^', '^='):
543543
return self.bool_bitwise_op(lreg, rreg, op[0], line)
544544

545-
call_c_ops_candidates = c_binary_ops.get(op, [])
545+
call_c_ops_candidates = binary_ops.get(op, [])
546546
target = self.matching_call_c(call_c_ops_candidates, [lreg, rreg], line)
547547
assert target, 'Unsupported binary operation: %s' % op
548548
return target
@@ -749,7 +749,7 @@ def unary_op(self,
749749
line: int) -> Value:
750750
if (is_bool_rprimitive(lreg.type) or is_bit_rprimitive(lreg.type)) and expr_op == 'not':
751751
return self.unary_not(lreg, line)
752-
call_c_ops_candidates = c_unary_ops.get(expr_op, [])
752+
call_c_ops_candidates = unary_ops.get(expr_op, [])
753753
target = self.matching_call_c(call_c_ops_candidates, [lreg], line)
754754
assert target, 'Unsupported unary operation: %s' % expr_op
755755
return target
@@ -813,7 +813,7 @@ def builtin_call(self,
813813
args: List[Value],
814814
fn_op: str,
815815
line: int) -> Value:
816-
call_c_ops_candidates = c_function_ops.get(fn_op, [])
816+
call_c_ops_candidates = function_ops.get(fn_op, [])
817817
target = self.matching_call_c(call_c_ops_candidates, args, line)
818818
assert target, 'Unsupported builtin function: %s' % fn_op
819819
return target
@@ -1081,7 +1081,7 @@ def translate_special_method_call(self,
10811081
10821082
Return None if no translation found; otherwise return the target register.
10831083
"""
1084-
call_c_ops_candidates = c_method_call_ops.get(name, [])
1084+
call_c_ops_candidates = method_call_ops.get(name, [])
10851085
call_c_op = self.matching_call_c(call_c_ops_candidates, [base_reg] + args,
10861086
line, result_type)
10871087
return call_c_op

mypyc/primitives/dict_ops.py

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
)
99

1010
from mypyc.primitives.registry import (
11-
c_custom_op, c_method_op, c_function_op, c_binary_op, load_address_op, ERR_NEG_INT
11+
custom_op, method_op, function_op, binary_op, load_address_op, ERR_NEG_INT
1212
)
1313

1414
# Get the 'dict' type object.
@@ -18,23 +18,23 @@
1818
src='PyDict_Type')
1919

2020
# dict[key]
21-
dict_get_item_op = c_method_op(
21+
dict_get_item_op = method_op(
2222
name='__getitem__',
2323
arg_types=[dict_rprimitive, object_rprimitive],
2424
return_type=object_rprimitive,
2525
c_function_name='CPyDict_GetItem',
2626
error_kind=ERR_MAGIC)
2727

2828
# dict[key] = value
29-
dict_set_item_op = c_method_op(
29+
dict_set_item_op = method_op(
3030
name='__setitem__',
3131
arg_types=[dict_rprimitive, object_rprimitive, object_rprimitive],
3232
return_type=c_int_rprimitive,
3333
c_function_name='CPyDict_SetItem',
3434
error_kind=ERR_NEG_INT)
3535

3636
# key in dict
37-
c_binary_op(
37+
binary_op(
3838
name='in',
3939
arg_types=[object_rprimitive, dict_rprimitive],
4040
return_type=c_int_rprimitive,
@@ -44,7 +44,7 @@
4444
ordering=[1, 0])
4545

4646
# dict1.update(dict2)
47-
dict_update_op = c_method_op(
47+
dict_update_op = method_op(
4848
name='update',
4949
arg_types=[dict_rprimitive, dict_rprimitive],
5050
return_type=c_int_rprimitive,
@@ -54,38 +54,38 @@
5454

5555
# Operation used for **value in dict displays.
5656
# This is mostly like dict.update(obj), but has customized error handling.
57-
dict_update_in_display_op = c_custom_op(
57+
dict_update_in_display_op = custom_op(
5858
arg_types=[dict_rprimitive, dict_rprimitive],
5959
return_type=c_int_rprimitive,
6060
c_function_name='CPyDict_UpdateInDisplay',
6161
error_kind=ERR_NEG_INT)
6262

6363
# dict.update(obj)
64-
c_method_op(
64+
method_op(
6565
name='update',
6666
arg_types=[dict_rprimitive, object_rprimitive],
6767
return_type=c_int_rprimitive,
6868
c_function_name='CPyDict_UpdateFromAny',
6969
error_kind=ERR_NEG_INT)
7070

7171
# dict.get(key, default)
72-
c_method_op(
72+
method_op(
7373
name='get',
7474
arg_types=[dict_rprimitive, object_rprimitive, object_rprimitive],
7575
return_type=object_rprimitive,
7676
c_function_name='CPyDict_Get',
7777
error_kind=ERR_MAGIC)
7878

7979
# dict.get(key)
80-
c_method_op(
80+
method_op(
8181
name='get',
8282
arg_types=[dict_rprimitive, object_rprimitive],
8383
return_type=object_rprimitive,
8484
c_function_name='CPyDict_GetWithNone',
8585
error_kind=ERR_MAGIC)
8686

8787
# Construct an empty dictionary.
88-
dict_new_op = c_custom_op(
88+
dict_new_op = custom_op(
8989
arg_types=[],
9090
return_type=dict_rprimitive,
9191
c_function_name='PyDict_New',
@@ -94,15 +94,15 @@
9494
# Construct a dictionary from keys and values.
9595
# Positional argument is the number of key-value pairs
9696
# Variable arguments are (key1, value1, ..., keyN, valueN).
97-
dict_build_op = c_custom_op(
97+
dict_build_op = custom_op(
9898
arg_types=[c_pyssize_t_rprimitive],
9999
return_type=dict_rprimitive,
100100
c_function_name='CPyDict_Build',
101101
error_kind=ERR_MAGIC,
102102
var_arg_type=object_rprimitive)
103103

104104
# Construct a dictionary from another dictionary.
105-
c_function_op(
105+
function_op(
106106
name='builtins.dict',
107107
arg_types=[dict_rprimitive],
108108
return_type=dict_rprimitive,
@@ -111,103 +111,103 @@
111111
priority=2)
112112

113113
# Generic one-argument dict constructor: dict(obj)
114-
c_function_op(
114+
function_op(
115115
name='builtins.dict',
116116
arg_types=[object_rprimitive],
117117
return_type=dict_rprimitive,
118118
c_function_name='CPyDict_FromAny',
119119
error_kind=ERR_MAGIC)
120120

121121
# dict.keys()
122-
c_method_op(
122+
method_op(
123123
name='keys',
124124
arg_types=[dict_rprimitive],
125125
return_type=object_rprimitive,
126126
c_function_name='CPyDict_KeysView',
127127
error_kind=ERR_MAGIC)
128128

129129
# dict.values()
130-
c_method_op(
130+
method_op(
131131
name='values',
132132
arg_types=[dict_rprimitive],
133133
return_type=object_rprimitive,
134134
c_function_name='CPyDict_ValuesView',
135135
error_kind=ERR_MAGIC)
136136

137137
# dict.items()
138-
c_method_op(
138+
method_op(
139139
name='items',
140140
arg_types=[dict_rprimitive],
141141
return_type=object_rprimitive,
142142
c_function_name='CPyDict_ItemsView',
143143
error_kind=ERR_MAGIC)
144144

145145
# list(dict.keys())
146-
dict_keys_op = c_custom_op(
146+
dict_keys_op = custom_op(
147147
arg_types=[dict_rprimitive],
148148
return_type=list_rprimitive,
149149
c_function_name='CPyDict_Keys',
150150
error_kind=ERR_MAGIC)
151151

152152
# list(dict.values())
153-
dict_values_op = c_custom_op(
153+
dict_values_op = custom_op(
154154
arg_types=[dict_rprimitive],
155155
return_type=list_rprimitive,
156156
c_function_name='CPyDict_Values',
157157
error_kind=ERR_MAGIC)
158158

159159
# list(dict.items())
160-
dict_items_op = c_custom_op(
160+
dict_items_op = custom_op(
161161
arg_types=[dict_rprimitive],
162162
return_type=list_rprimitive,
163163
c_function_name='CPyDict_Items',
164164
error_kind=ERR_MAGIC)
165165

166166
# PyDict_Next() fast iteration
167-
dict_key_iter_op = c_custom_op(
167+
dict_key_iter_op = custom_op(
168168
arg_types=[dict_rprimitive],
169169
return_type=object_rprimitive,
170170
c_function_name='CPyDict_GetKeysIter',
171171
error_kind=ERR_MAGIC)
172172

173-
dict_value_iter_op = c_custom_op(
173+
dict_value_iter_op = custom_op(
174174
arg_types=[dict_rprimitive],
175175
return_type=object_rprimitive,
176176
c_function_name='CPyDict_GetValuesIter',
177177
error_kind=ERR_MAGIC)
178178

179-
dict_item_iter_op = c_custom_op(
179+
dict_item_iter_op = custom_op(
180180
arg_types=[dict_rprimitive],
181181
return_type=object_rprimitive,
182182
c_function_name='CPyDict_GetItemsIter',
183183
error_kind=ERR_MAGIC)
184184

185-
dict_next_key_op = c_custom_op(
185+
dict_next_key_op = custom_op(
186186
arg_types=[object_rprimitive, int_rprimitive],
187187
return_type=dict_next_rtuple_single,
188188
c_function_name='CPyDict_NextKey',
189189
error_kind=ERR_NEVER)
190190

191-
dict_next_value_op = c_custom_op(
191+
dict_next_value_op = custom_op(
192192
arg_types=[object_rprimitive, int_rprimitive],
193193
return_type=dict_next_rtuple_single,
194194
c_function_name='CPyDict_NextValue',
195195
error_kind=ERR_NEVER)
196196

197-
dict_next_item_op = c_custom_op(
197+
dict_next_item_op = custom_op(
198198
arg_types=[object_rprimitive, int_rprimitive],
199199
return_type=dict_next_rtuple_pair,
200200
c_function_name='CPyDict_NextItem',
201201
error_kind=ERR_NEVER)
202202

203203
# check that len(dict) == const during iteration
204-
dict_check_size_op = c_custom_op(
204+
dict_check_size_op = custom_op(
205205
arg_types=[dict_rprimitive, int_rprimitive],
206206
return_type=bit_rprimitive,
207207
c_function_name='CPyDict_CheckSize',
208208
error_kind=ERR_FALSE)
209209

210-
dict_size_op = c_custom_op(
210+
dict_size_op = custom_op(
211211
arg_types=[dict_rprimitive],
212212
return_type=c_pyssize_t_rprimitive,
213213
c_function_name='PyDict_Size',

mypyc/primitives/exc_ops.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,46 +2,46 @@
22

33
from mypyc.ir.ops import ERR_NEVER, ERR_FALSE, ERR_ALWAYS
44
from mypyc.ir.rtypes import object_rprimitive, void_rtype, exc_rtuple, bit_rprimitive
5-
from mypyc.primitives.registry import c_custom_op
5+
from mypyc.primitives.registry import custom_op
66

77
# If the argument is a class, raise an instance of the class. Otherwise, assume
88
# that the argument is an exception object, and raise it.
9-
raise_exception_op = c_custom_op(
9+
raise_exception_op = custom_op(
1010
arg_types=[object_rprimitive],
1111
return_type=void_rtype,
1212
c_function_name='CPy_Raise',
1313
error_kind=ERR_ALWAYS)
1414

1515
# Raise StopIteration exception with the specified value (which can be NULL).
16-
set_stop_iteration_value = c_custom_op(
16+
set_stop_iteration_value = custom_op(
1717
arg_types=[object_rprimitive],
1818
return_type=void_rtype,
1919
c_function_name='CPyGen_SetStopIterationValue',
2020
error_kind=ERR_ALWAYS)
2121

2222
# Raise exception with traceback.
2323
# Arguments are (exception type, exception value, traceback).
24-
raise_exception_with_tb_op = c_custom_op(
24+
raise_exception_with_tb_op = custom_op(
2525
arg_types=[object_rprimitive, object_rprimitive, object_rprimitive],
2626
return_type=void_rtype,
2727
c_function_name='CPyErr_SetObjectAndTraceback',
2828
error_kind=ERR_ALWAYS)
2929

3030
# Reraise the currently raised exception.
31-
reraise_exception_op = c_custom_op(
31+
reraise_exception_op = custom_op(
3232
arg_types=[],
3333
return_type=void_rtype,
3434
c_function_name='CPy_Reraise',
3535
error_kind=ERR_ALWAYS)
3636

3737
# Propagate exception if the CPython error indicator is set (an exception was raised).
38-
no_err_occurred_op = c_custom_op(
38+
no_err_occurred_op = custom_op(
3939
arg_types=[],
4040
return_type=bit_rprimitive,
4141
c_function_name='CPy_NoErrOccured',
4242
error_kind=ERR_FALSE)
4343

44-
err_occurred_op = c_custom_op(
44+
err_occurred_op = custom_op(
4545
arg_types=[],
4646
return_type=object_rprimitive,
4747
c_function_name='PyErr_Occurred',
@@ -50,7 +50,7 @@
5050

5151
# Keep propagating a raised exception by unconditionally giving an error value.
5252
# This doesn't actually raise an exception.
53-
keep_propagating_op = c_custom_op(
53+
keep_propagating_op = custom_op(
5454
arg_types=[],
5555
return_type=bit_rprimitive,
5656
c_function_name='CPy_KeepPropagating',
@@ -60,36 +60,36 @@
6060
# handled exception" (by sticking it into sys.exc_info()). Returns the
6161
# exception that was previously being handled, which must be restored
6262
# later.
63-
error_catch_op = c_custom_op(
63+
error_catch_op = custom_op(
6464
arg_types=[],
6565
return_type=exc_rtuple,
6666
c_function_name='CPy_CatchError',
6767
error_kind=ERR_NEVER)
6868

6969
# Restore an old "currently handled exception" returned from.
7070
# error_catch (by sticking it into sys.exc_info())
71-
restore_exc_info_op = c_custom_op(
71+
restore_exc_info_op = custom_op(
7272
arg_types=[exc_rtuple],
7373
return_type=void_rtype,
7474
c_function_name='CPy_RestoreExcInfo',
7575
error_kind=ERR_NEVER)
7676

7777
# Checks whether the exception currently being handled matches a particular type.
78-
exc_matches_op = c_custom_op(
78+
exc_matches_op = custom_op(
7979
arg_types=[object_rprimitive],
8080
return_type=bit_rprimitive,
8181
c_function_name='CPy_ExceptionMatches',
8282
error_kind=ERR_NEVER)
8383

8484
# Get the value of the exception currently being handled.
85-
get_exc_value_op = c_custom_op(
85+
get_exc_value_op = custom_op(
8686
arg_types=[],
8787
return_type=object_rprimitive,
8888
c_function_name='CPy_GetExcValue',
8989
error_kind=ERR_NEVER)
9090

9191
# Get exception info (exception type, exception instance, traceback object).
92-
get_exc_info_op = c_custom_op(
92+
get_exc_info_op = custom_op(
9393
arg_types=[],
9494
return_type=exc_rtuple,
9595
c_function_name='CPy_GetExcInfo',

0 commit comments

Comments
 (0)