Merge pull request #234 from python/bugfix/as_file-refleak

Avoid file descriptor refleaks in as_file.

Author: jaraco

CHANGES.rst

@@ -1,3 +1,8 @@
+v5.2.2
+======
+
+* #234: Fix refleak in ``as_file`` caught by CPython tests.
+
 v5.2.1
 ======
 

importlib_resources/_common.py

@@ -87,14 +87,16 @@ def _tempfile(reader, suffix=''):
     # properly.
     fd, raw_path = tempfile.mkstemp(suffix=suffix)
     try:
-        os.write(fd, reader())
-        os.close(fd)
+        try:
+            os.write(fd, reader())
+        finally:
+            os.close(fd)
         del reader
         yield pathlib.Path(raw_path)
     finally:
         try:
             os.remove(raw_path)
-        except (FileNotFoundError, PermissionError):
+        except FileNotFoundError:
             pass