gh-90928: Improve static initialization of keywords tuple in AC #95907
Conversation
Deduce num_keywords from f.parameters
erlend-aasland
requested review from
a team,
1st1,
abalkin,
asvetlov,
berkerpeksag,
ethanfurman,
pganssle,
rhettinger and
tiran
as code owners
erlend-aasland
removed request for
a team,
1st1,
abalkin,
asvetlov,
berkerpeksag,
ethanfurman,
pganssle,
rhettinger and
tiran
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Thanks for working on this! Mostly LGTM.
Also, can you drop "num_keywords" from template_dict now?
|
When you're done making the requested changes, leave the comment: |
It is already dropped :) |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ericsnowcurrently: please review the changes made to this pull request. |
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
I'll leave it up to you about the two comments I left.
Co-authored-by: Eric Snow <[email protected]>
|
Thanks for reviewing; highly appreciated. I'll make a quick adjustment before landing. |
- inline len(keywords) - use NUM_KEYWORDS constant for improved readability in generated code
|
I'm done with the last round of adjustments. I ended up adding both of your last suggestions. Thanks again. |
|
FYI, I'll wait with merging until Kumar has finished his review. |
|
Thanks for the reviews! |
4 participants
Calculate
num_keywordsduring template generation instead of leaving it to the preprocessor. This makes for much smaller and easier to read (FWIW) AC output.See discussion in #95860 (comment)