bpo-33451: Close .pyc files before calling PyEval_EvalCode() #7884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.pyc files were kept open longer than necessary.
ncoghlan
approved these changes
Jun 24, 2018
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
LGTM (I explicitly checked that run_pyc_file is a private helper function inside pythonrun.c, so there's no externally visible change in behaviour other than the intended one of closing the pyc file before we start executing the code)
Contributor
|
Thanks @ZackerySpytz for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Contributor
|
Thanks @ZackerySpytz for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-7888 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2018
…-7884) Directly executed pyc files were being kept open longer than necessary. (cherry picked from commit ea73775) Co-authored-by: Zackery Spytz <[email protected]>
|
GH-7889 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2018
…-7884) Directly executed pyc files were being kept open longer than necessary. (cherry picked from commit ea73775) Co-authored-by: Zackery Spytz <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 24, 2018
Directly executed pyc files were being kept open longer than necessary. (cherry picked from commit ea73775) Co-authored-by: Zackery Spytz <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 24, 2018
Directly executed pyc files were being kept open longer than necessary. (cherry picked from commit ea73775) Co-authored-by: Zackery Spytz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.pyc files were kept open longer than necessary.
https://bugs.python.org/issue33451