-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
bpo-44207: Add an internal version number to function objects. #27078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-44207: Add an internal version number to function objects. #27078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to set a version tag for these too?
- PyFunction_SetDefaults
- PyFunction_SetKwDefaults
- PyFunction_SetClosure
- PyFunction_SetAnnotations
|
Yes, thanks. |
|
Mostly LGTM now. BTW, should setting a function's Currently, it's |
|
We don't care what is in the function's |
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright thanks. LGTM!
|
Will be used in much the same way as the version numbers on classes and dictionary keys.
Provides us a fast way to check that the function object is in the same state as when we specialize code for it.
https://bugs.python.org/issue44207