Skip to content

Revert "bpo-30822: Fix testing of datetime module." #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 5, 2017
Merged

Revert "bpo-30822: Fix testing of datetime module." #2588

merged 15 commits into from
Jul 5, 2017

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jul 5, 2017

Reverts #2530

vstinner added 15 commits July 5, 2017 14:43
@vstinner
Revert "bpo-30854: Fix compile error when --without-threads (#2581)"
431890d 
This reverts commit 0c31163.
@vstinner
Revert "NEWS for 30777 (#2576)"
02126d8 
This reverts commit aaa917f.
@vstinner
Revert "bpo-21624: IDLE -- minor htest fixes (#2575)"
a73af89 
This reverts commit 2000150.
@vstinner
Revert "bpo-30777: IDLE: configdialog - add docstrings and improve co…
5dace3a 
…mments (#2440)"

This reverts commit 7eb5883.
@vstinner
Revert "bpo-30319: socket.close() now ignores ECONNRESET (#2565)"
be9e61f 
This reverts commit 67e1478.
@vstinner
Revert "bpo-30789: Use a single memory block for co_extra. (#2555)"
e2dde13 
This reverts commit 378ebb6.
@vstinner
Revert "bpo-30845: Enhance test_concurrent_futures cleanup (#2564)"
232c174 
This reverts commit 3df9dec.
@vstinner
Revert "bpo-29293: multiprocessing.Condition.notify() lacks parameter…
eefb178 
… `n` (#2480)"

This reverts commit 4835041.
@vstinner
Revert "Remove outdated FOX from GUI FAQ (GH-2538)"
7d444a6 
This reverts commit d3ed287.
@vstinner
Revert "bpo-6691: Pyclbr now reports nested classes and functions. (#…
957a410 
…2503)"

This reverts commit 246ff3b.
@vstinner
Revert "bpo-29464: Rename METH_FASTCALL to METH_FASTCALL|METH_KEYWORD…
5af7f2e 
…S and make (#1955)"

This reverts commit 6969eaf.
@vstinner
Revert "bpo-30832: Remove own implementation for thread-local storage (…
74e1e19 
…#2537)"

This reverts commit aa0aa04.
@vstinner
Revert "bpo-30764: Fix regrtest --fail-env-changed --forever (#2536)"
92b6e58 
This reverts commit 5e87592.
@vstinner
Revert "bpo-30822: Deduplicate ZoneInfoTest classes in test_datetime. (…
bc551d3 
…#2534)"

This reverts commit 34b5487.
@vstinner
Revert "bpo-30822: Fix testing of datetime module. (#2530)"
f7149af 
This reverts commit 98b6bc3.
@mention-bot
Copy link

mention-bot commented Jul 5, 2017

@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abalkin, @birkenfeld and @serhiy-storchaka to be potential reviewers.

@vstinner
Copy link
Member Author

vstinner commented Jul 5, 2017

I propose to revert the change because test_datetime now takes up to 20 minutes, which causes random failures, especially on the slow "ARMv7 Ubuntu 3.x" buildbot:
http://bugs.python.org/issue30822#msg297734

This revert is part of the new policy to keep buildbots green:
https://mail.python.org/pipermail/python-committers/2017-June/004588.html

The revert is just a solution to get more time to fix a proper fix, before reapply the commit.

@vstinner vstinner merged commit 8207c17 into master Jul 5, 2017
@vstinner vstinner deleted the revert-2530-bpo-30822 branch July 5, 2017 13:44
This was referenced Jul 5, 2017
Closed
Closed
@musically-ut musically-ut mentioned this pull request Jul 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @mention-bot @the-knights-who-say-ni