Skip to content

[3.9] Fix typos in unittest documentation (GH-24194) #24267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2021
Merged

[3.9] Fix typos in unittest documentation (GH-24194) #24267

merged 1 commit into from
Mar 14, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 20, 2021

  • addCleanupClass -> addClassCleanup
  • doCleanupsClass -> doClassCleanups
    (cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor [email protected]

@Conchylicultor @miss-islington
Fix typos in unittest documentation (pythonGH-24194)
997d777 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <[email protected]>
@bedevere-bot bedevere-bot added skip issue skip news docs Documentation in the Doc dir labels Jan 20, 2021
@bedevere-bot bedevere-bot mentioned this pull request Jan 20, 2021
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 20, 2021

@Conchylicultor and @tirkarthi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 20, 2021

@Conchylicultor and @tirkarthi: Status check is done, and it's a success ✅ .

3 similar comments
@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 20, 2021

@Conchylicultor and @tirkarthi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 20, 2021

@Conchylicultor and @tirkarthi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 20, 2021

@Conchylicultor and @tirkarthi: Status check is done, and it's a success ✅ .

tirkarthi
tirkarthi approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

serverwentdown
serverwentdown approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@serverwentdown serverwentdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Mar 14, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 14, 2021
@miss-islington miss-islington merged commit bb46c13 into python:3.9 Mar 14, 2021
@miss-islington miss-islington deleted the backport-e0e398e-3.9 branch March 14, 2021 00:28
@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 14, 2021

@Conchylicultor and @tirkarthi: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

+1 more reviewer

@serverwentdown serverwentdown serverwentdown approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington @serverwentdown @tirkarthi @the-knights-who-say-ni @bedevere-bot @Conchylicultor